From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32352: 27.0.50; build error Date: Mon, 12 Nov 2018 20:37:09 -0500 Message-ID: <87lg5xhi62.fsf@gmail.com> References: <83600sueox.fsf@gnu.org> <87d0uzzkqb.fsf@gmail.com> <3ein126rxn.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542072969 29881 195.159.176.226 (13 Nov 2018 01:36:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2018 01:36:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: markusffm@fn.de, 32352@debbugs.gnu.org, Katsumi Yamaoka To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 13 02:36:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMNca-0007d0-S3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Nov 2018 02:36:05 +0100 Original-Received: from localhost ([::1]:51529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMNeg-0005P6-Sf for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Nov 2018 20:38:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMNeZ-0005Oz-Vc for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 20:38:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMNeW-0001Ed-8G for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 20:38:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMNeU-0001EM-RC for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 20:38:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gMNeU-0000Ck-FP for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 20:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Nov 2018 01:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32352 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32352-submit@debbugs.gnu.org id=B32352.1542073038702 (code B ref 32352); Tue, 13 Nov 2018 01:38:02 +0000 Original-Received: (at 32352) by debbugs.gnu.org; 13 Nov 2018 01:37:18 +0000 Original-Received: from localhost ([127.0.0.1]:48465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMNdm-0000BG-4Q for submit@debbugs.gnu.org; Mon, 12 Nov 2018 20:37:18 -0500 Original-Received: from mail-io1-f52.google.com ([209.85.166.52]:33234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMNdk-0000B3-NM for 32352@debbugs.gnu.org; Mon, 12 Nov 2018 20:37:17 -0500 Original-Received: by mail-io1-f52.google.com with SMTP id f12-v6so7710753iog.0 for <32352@debbugs.gnu.org>; Mon, 12 Nov 2018 17:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+cZ2MJJsdQfYonTdXZKDGLIi2o8UoB3HpdbcJLD3KMI=; b=OuWSA7wXuPV+weyNr2H8VTElywNar9/ZW//EaLxvQLbLP4qGtrLLSutx9EwCcPjp0m 4X+mtFwYf47aVLJJg/V5FK3G/a1SVSeUx0ck5cTfPPPkKqtqVoqlcqKwWhvfXz2hGtlP zJzuitho3hwam6EF9pL1r3DJONkYKIq4gUbu57kR91LXwKTAUcaaiUPxj3NFb/gqQVAu 6s0Q1E0J8DXoNH4zYPoGkDaYu/Z16GgXcN557waffyQVe8CPzpaFVBzIknUqSSvw4mGL Fd5hUHavyKzrOKfkvOl6fjuGVX2JViVAE+uxF0n/kvBTJAVv7p+5xnMcX8vNTLbofs5n znrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+cZ2MJJsdQfYonTdXZKDGLIi2o8UoB3HpdbcJLD3KMI=; b=sfHAgJWQBZ+QORxYwI2s3iGJE2hktZsISy+kle9Zs14XjoD1FgZVHUlw7hvQG+dvyY mTrcIBMiG/US3EM+/NYLuwrTyMtssKp19ldhKJShBY+JtJO2patsGFWuLwbr9wShxDME 79/fGZ5W2fnkiZPNeaYgifpdZc2h1kwJAdFtumJVXW+nVoBTbsEjE/pcp/OXF0pER9xU HJpAjQgUZb417E7MCe/e2jSPXVF122PR/wOeTHZ/b9o6aog+4lZhlA/vzhw6508+uhOt /68VhrwdAj4j8c6DyZw7UactQ29S6zNoexUmtVvWtrJdOzwWaYV7LTCWoF4RhDNtMqr7 HRsw== X-Gm-Message-State: AGRZ1gLLv20SSEAWUmlHbaRfvQd0CnXofvkmtvhXj0OZ7MumLGveQB95 Jol0JVpTS+Lmuvzmuf/UymY= X-Google-Smtp-Source: AJdET5ceA9RHcw5dBQgffcwyW1mtWeOxFrYDCsi5m95yu2/xsQUrdrZO5SWnoyhELiR8rOhifIRarA== X-Received: by 2002:a6b:3989:: with SMTP id g131-v6mr2664391ioa.67.1542073031033; Mon, 12 Nov 2018 17:37:11 -0800 (PST) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u3-v6sm5930731iog.33.2018.11.12.17.37.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Nov 2018 17:37:10 -0800 (PST) In-Reply-To: <3ein126rxn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 12 Nov 2018 14:01:40 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152331 Archived-At: Glenn Morris writes: > I seem to be able to reproduce it at will with (after a bootstrap): > > touch lisp/files.el src/emacs.c > rm src/bootstrap-emacs > make Ah right, I missed removing bootstrap-emacs. > which dies doing > > ./src/bootstrap-emacs -batch -f batch-byte-compile lisp/files.el > > at (alist-get class dir-locals-class-alist) when gv.elc loads. > (It's fine if you load bytecomp.el instead of .elc.) Not entirely sure about bytecomp.el vs elc, but the problem seems to be that files.el binds read-circle over too much code, and gv.elc has some circular structure in it. The following patch fixes it: --- c/lisp/files.el +++ i/lisp/files.el @@ -4099,7 +4099,6 @@ dir-locals-read-from-dir Return the new class name, which is a symbol named DIR." (let* ((class-name (intern dir)) (files (dir-locals--all-files dir)) - (read-circle nil) ;; If there was a problem, use the values we could get but ;; don't let the cache prevent future reads. (latest 0) (success 0) @@ -4114,7 +4113,8 @@ dir-locals-read-from-dir (insert-file-contents file) (let ((newvars (condition-case-unless-debug nil - (read (current-buffer)) + (let ((read-circle nil)) + (read (current-buffer))) (end-of-file nil)))) (setq variables ;; Try and avoid loading `map' since that also loads cl-lib I guess this could go to emacs-26 (although I'm suddenly unable to build it today, I get tons of "undefined reference to X" link errors (including X=main!?)).