From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode Date: Tue, 05 Feb 2019 18:59:16 +0100 Message-ID: <87lg2uunez.fsf@gmx.de> References: <87lg36m2rp.fsf@gmx.de> <8736p3bnjh.fsf@gmx.de> <877eeewg8c.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="79596"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34196@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 05 19:21:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gr5Le-000KXt-Sp for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2019 19:21:31 +0100 Original-Received: from localhost ([127.0.0.1]:37123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr5Ld-0006eQ-NK for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2019 13:21:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr50u-0005J4-4N for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 13:00:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gr50t-0006fE-9Y for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 13:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gr50t-0006eK-66 for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 13:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gr50s-00069F-RY for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 13:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2019 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34196 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34196-submit@debbugs.gnu.org id=B34196.154938956623547 (code B ref 34196); Tue, 05 Feb 2019 18:00:02 +0000 Original-Received: (at 34196) by debbugs.gnu.org; 5 Feb 2019 17:59:26 +0000 Original-Received: from localhost ([127.0.0.1]:33732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gr50I-00067i-G9 for submit@debbugs.gnu.org; Tue, 05 Feb 2019 12:59:26 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:56379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gr50H-00067U-6u for 34196@debbugs.gnu.org; Tue, 05 Feb 2019 12:59:25 -0500 Original-Received: from detlef.gmx.de ([213.220.158.98]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MV30j-1gcTaF0pi9-00YN7E; Tue, 05 Feb 2019 18:59:18 +0100 In-Reply-To: (Aaron Jensen's message of "Tue, 5 Feb 2019 08:43:52 -0800") X-Provags-ID: V03:K1:p0BqoUHlnFDsvE1jUC8HNuGWE2jXOa1AhLoVYgkzxe3TJkUQavk 0LpMQ2yHuCRjGccRZ68mstBlQ59Wic8RZyWpsHAVxUNWfgLhFF8BWDdypFJbvVPVE5Wj6sN VurjV6J8pPz/A5tYHVsgWkuSv8OrxlKS6ZNOKQc143nCmvzNwAlgVpFksD1LZ2jUJjNL5ho EwXy/wIHiI4vgfB5QvVVw== X-UI-Out-Filterresults: notjunk:1;V03:K0:yEao3CsHXik=:T+jFTkmj9YT4iEojCAfp7T +6wKqWApYz0asN6T23Iggfoj+pedJsRlekH2xM7/5+gx/UOqrq+16PSbssxBvGQsaTUP20Fre /ihAcBfg+/YbnelBNAALJYCM821htTwdbmStL0iL3yxFdwjWdw0NRtl9m1Ixk2fdxfgKlqpaX igA1SNRIAq7j9r6TyQMQcFxKF2j6gO7bE+gMk9vwVHwC1fsrHdG1MGDluhQ9t2gFJARdSJww9 CWBoPAdvTqeZCm34/qrFZnXmp1oMu5XpN0E/2SVeih2LaJDBexs4hFkwle+qwOX8S3tFb3++Y m14XqY1halb+XqqbI9lol/SwK6hmQFiuivR9S/Te7rXckaSwWuopOeKSEuf2cM2PtlKF+LiNB p0IbXPZ7es4YdZs9wIYG+8S1rZu05ffTXOYhUYUbwZsOGS0XxSzBM0eZFIpRzIU7WTssaUooK SxwnWP42WV2FAS5Tr/ETRIofeQrLt/h542l8WJwMdzTGOl03g9uZHiXIcPXfjtFXDBG0szQP0 BMy2JggJtXhn38+4NY78WjWcyF1aiNQy7RHZHLF5voG5kZTnRufGzP7sMSVr6nCI7kEua0teg F4jiKcfygSlZkZFLACAEiKPZphx3+Lrs6kXKxdNZy3gKlG+7E8iEN9Zr0URiXJuXg1HswR/L/ eHUHDMpsCezLNZSKuR9PA+L8GejzBIc0FRaQmQ84XnwhYnDc4BQsFWLGHQyAesMmwsoNfaMIm FQfzydPe4eyYPd9MmC+GULPNNltXCDBSnfp4IcqRyMTdNmdLYrSyrrxWc1JMaGE8hemFlt0J X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155146 Archived-At: Aaron Jensen writes: Hi Aaron, > Is there any cost to an extra loop over all buffers and doing > with-current-buffer? There is cost, but not too much. `file-remote-p' doesn't go remote, and it is fast: (let ((default-directory "/sudo::")) (benchmark 1000 (with-temp-buffer (file-remote-p default-directory)))) => Elapsed time: 0.000060s > I wonder if a change to auto-revert-active-p would be better than > looping through all of the buffers and with-current-buffering them > again. I don't know if that's semantically wrong for that function. I've played with this idea as well. But the call is much too late for our purposes (somewhere in the middle of auto-revert-buffers) > Another option is putting a check in auto-revert-notify-add-watch, > since that already has checks to ensure the file is okay to be > watched: > > (or auto-revert-notify-watch-descriptor > (and (file-remote-p default-directory) > (not (file-remote-p default-directory nil t))) > (string-match auto-revert-notify-exclude-dir-regexp > (expand-file-name default-directory)) > (file-symlink-p (or buffer-file-name default-directory))) > > With that in place, even if I enable auto-revert-remote-files I don't > experience the hang. Yes, I've played with this also. auto-revert-notify-add-watch comes in place when file notification is used. That's not the case, always. So I tend to push my patch, if nobody complains. Let's sleep over this :-) > Thanks, > > Aaron Best regards, Michael.