From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Date: Sun, 24 Feb 2019 08:47:25 -0600 Message-ID: <87lg256y6a.fsf@gmail.com> References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> <83zhqmq44v.fsf@gnu.org> <87va1ask2c.fsf@gmail.com> <83h8cuphfp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="104150"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 33975@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 24 15:48:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxv4f-000R13-LE for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 15:48:13 +0100 Original-Received: from localhost ([127.0.0.1]:52252 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxv4e-0006GP-Gf for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 09:48:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxv4X-0006G9-Tn for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 09:48:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxv4X-0005lT-59 for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 09:48:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36365) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxv4W-0005k7-5u for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 09:48:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxv4T-00012g-Od for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 09:48:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Feb 2019 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.15510196583975 (code B ref 33975); Sun, 24 Feb 2019 14:48:01 +0000 Original-Received: (at 33975) by debbugs.gnu.org; 24 Feb 2019 14:47:38 +0000 Original-Received: from localhost ([127.0.0.1]:49909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxv46-000123-A4 for submit@debbugs.gnu.org; Sun, 24 Feb 2019 09:47:38 -0500 Original-Received: from mail-ot1-f68.google.com ([209.85.210.68]:34946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxv44-00011p-Ha for 33975@debbugs.gnu.org; Sun, 24 Feb 2019 09:47:36 -0500 Original-Received: by mail-ot1-f68.google.com with SMTP id z19so5783257otm.2 for <33975@debbugs.gnu.org>; Sun, 24 Feb 2019 06:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=a34PgE+RuiouJJBYnhGPzMD08R+n73QL5milURmTtAA=; b=Z8DQ87TDWkAYPkagDsQcFG80Aitw7R87PQVhcCKCH8fdpUhAmsf5xVYhwacC7adUfQ x6a2USQXoVKJg85naktiITXhRpBaPNCgpXKFyjM27qqK4IOQNenY0pbG0AgNj6V6oFBE Y6L+BVyzvw77EtruAb02Lrv1TR7l7OVRDN559FWFiJ9D+iuHBMI5GUImHOYEenz930Xm Zhjwjn2luDQXQOswymg6X5cFkwhdLtPuwi58duL+PZYw0YsstC6xXnluQWUEUZBA3X/n MJdY+BgTozwKxzT9M4fSyf91xZEjO4Krj8pZiNAYL0BmaVFrv6lGM5A2X8BUed9QN9je Ykkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=a34PgE+RuiouJJBYnhGPzMD08R+n73QL5milURmTtAA=; b=O7eIgkQe7VCml6CzArGtTZxhK/lprXW+Y4MAv/foLgUlPRdgzXbK65899nnkd7PsOO b1/hlCn2RM+q2rwrcrFTUyX5wYhj6kWFSkcRkXDF3cm7k9SKah4puhtcoVtLEDaLIKtJ 7rfUUj7emR8mGkHqHfse3RTILl4C9UUjzEN8VSzCzgxsD8VTH2cQ3IxguxbGM7URoyXo jwCIkdn3o4zaZEI2Bk8B9fLVRUv4R+I+jv7Ji6ldr2tic/22AA5S/tEjtxeud95WgRYV pbIVtpCNDVckpNrDFVRWwJ1riaq/1NqVle5H/dkWZYzzMKi/SjEdueID3V56rL6hUhMl EnfA== X-Gm-Message-State: AHQUAubt9bKgcyp5EdnKM49mlbrnNxrSWJmeozIsjD2xiC/Kp13XvxcR f/HhJV4jbHO6QP8CYPihCGe+soFW X-Google-Smtp-Source: AHgI3IaAn5ggTiuDZvGpbnZcU9XrFtS65h2XQ+NPC4JdzbNYDj3EyKher32R2pD08P7XmJJuIjojpw== X-Received: by 2002:a9d:2944:: with SMTP id d62mr1574065otb.193.1551019649701; Sun, 24 Feb 2019 06:47:29 -0800 (PST) Original-Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id a4sm3121469otc.21.2019.02.24.06.47.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Feb 2019 06:47:28 -0800 (PST) In-reply-to: <83h8cuphfp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155712 Archived-At: --=-=-= Content-Type: text/plain On Sat 23 Feb 2019 at 11:01, Eli Zaretskii wrote: >> (defun comint-skip-input () >> "Skip all pending input, from last stuff output by interpreter to point. >> -This means mark it as if it had been sent as input, without sending it." >> +This means mark it as if it had been sent as input, without >> +sending it. The command keys used to trigger this command are >> +inserted into the buffer." > > "this command" is inaccurate here, as comint-skip-input is not a > command. I'd say "the command which called this function" instead. > > Other than that, LGTM. Thanks. Great, thanks I'll make that change and push to master later today or tomorrow, unless I hear back otherwise. Alex --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxyrn0ACgkQHkInolPp msd+AggAiWnG+7i/E8N3/u+F5UQXXu+BSiz2THrGTQf0ztzMs6AZlFutC+exZAEY oL5GkV9azFmF06FhQtCwM06gyDU4MhK56nKX7MiU9N6lQsPFVw9kLPXfszBBQ6eh 6DDualGHRZOsHy4v6V7wgg2pPd6wJXuqcRT+imgEGhKXm78OgWOoRddNL6HzF4bq bnqQ+t1i0uK+hj+gCf5XRIJp5xDqr2QZHCMZnbzvWkmXAyWXF2I09qt4iOEw5MnO DEG3WTVoezADMozro2cutLCFWHeNtvKkOJ/+q/ob1bg5hAmpGLeaMfJ2HYMZGWrf wkoK3nA/SED9YXSh9an2iQCXrJNBrQ== =X6ub -----END PGP SIGNATURE----- --=-=-=--