From: Alex Branham <alex.branham@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33975@debbugs.gnu.org
Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
Date: Sun, 24 Feb 2019 08:47:25 -0600 [thread overview]
Message-ID: <87lg256y6a.fsf@gmail.com> (raw)
In-Reply-To: <83h8cuphfp.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Sat 23 Feb 2019 at 11:01, Eli Zaretskii <eliz@gnu.org> wrote:
>> (defun comint-skip-input ()
>> "Skip all pending input, from last stuff output by interpreter to point.
>> -This means mark it as if it had been sent as input, without sending it."
>> +This means mark it as if it had been sent as input, without
>> +sending it. The command keys used to trigger this command are
>> +inserted into the buffer."
>
> "this command" is inaccurate here, as comint-skip-input is not a
> command. I'd say "the command which called this function" instead.
>
> Other than that, LGTM. Thanks.
Great, thanks I'll make that change and push to master later today or
tomorrow, unless I hear back otherwise.
Alex
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-02-24 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:35 bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Alex Branham
2019-02-21 16:32 ` Alex Branham
2019-02-22 8:37 ` Eli Zaretskii
2019-02-22 21:26 ` Alex Branham
2019-02-23 8:51 ` Eli Zaretskii
2019-02-23 13:36 ` Alex Branham
2019-02-23 17:01 ` Eli Zaretskii
2019-02-24 14:47 ` Alex Branham [this message]
2019-02-25 1:11 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg256y6a.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=33975@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.