From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 34908@debbugs.gnu.org, "joão távora" <joaotavora@gmail.com>
Subject: bug#34908: Push mark in xref-push-marker-stack
Date: Wed, 20 Mar 2019 23:59:49 +0200 [thread overview]
Message-ID: <87lg192omi.fsf@mail.linkov.net> (raw)
In-Reply-To: <da112950-b252-e83e-4083-67020ac417af@yandex.ru> (Dmitry Gutov's message of "Wed, 20 Mar 2019 03:47:32 +0200")
>> I'm not sure where to call push-mark: closer to the command,
>> or closer to ring-insert. It seems a suitable place for
>> push-mark is in xref-push-marker-stack as its name suggests.
>
> I'd rather have a more localized change, at least for now. And leave
> xref-push-marker-stack to only modify its own data structure.
Do you think other commands that use xref-push-marker-stack
won't need setting the mark?
> So how about this?
>
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index 6974d00048..015ea16f34 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -797,6 +797,7 @@ xref--read-identifier-history
> (defvar xref--read-pattern-history nil)
>
> (defun xref--show-xrefs (xrefs display-action &optional always-show-list)
> + (push-mark nil t)
push-mark is usually called closer to the end of the command.
> (cond
> ((and (not (cdr xrefs)) (not always-show-list))
> (xref-push-marker-stack)
Some commands like e.g. ‘goto-line’ use such idiom:
(or (region-active-p) (push-mark))
documented in its docstring as
Prior to moving point, this function sets the mark (without
activating it), unless Transient Mark mode is enabled and the
mark is already active.
next prev parent reply other threads:[~2019-03-20 21:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 21:12 bug#34908: Push mark in xref-push-marker-stack Juri Linkov
2019-03-18 21:50 ` João Távora
2019-03-18 23:14 ` Dmitry Gutov
2019-03-19 21:02 ` Juri Linkov
2019-03-20 1:47 ` Dmitry Gutov
2019-03-20 21:59 ` Juri Linkov [this message]
2019-03-21 0:59 ` Dmitry Gutov
2019-03-19 6:16 ` Eli Zaretskii
2019-03-19 11:57 ` Dmitry Gutov
2019-03-19 20:59 ` Juri Linkov
2019-03-20 5:59 ` Eli Zaretskii
2019-03-20 21:49 ` Juri Linkov
2019-03-21 3:35 ` Eli Zaretskii
2019-03-24 21:20 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg192omi.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=34908@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.