From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35123: [PATCH] Use lexical-binding in bug-reference Date: Wed, 03 Apr 2019 17:42:31 +0100 Message-ID: <87lg0rrqfc.fsf@tcd.ie> References: <87wokbb18k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="259186"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35123@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 03 18:43:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBiyx-0015Io-LM for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 18:43:23 +0200 Original-Received: from localhost ([127.0.0.1]:58463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBiyu-0002XO-Oe for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 12:43:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBiyh-0002Tt-UB for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 12:43:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBiye-0000Al-Rp for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 12:43:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57837) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBiyd-0008PP-Rj for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 12:43:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBiyb-0004n3-O5 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 12:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35123-submit@debbugs.gnu.org id=B35123.155430976418391 (code B ref 35123); Wed, 03 Apr 2019 16:43:01 +0000 Original-Received: (at 35123) by debbugs.gnu.org; 3 Apr 2019 16:42:44 +0000 Original-Received: from localhost ([127.0.0.1]:43148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBiyK-0004mY-AI for submit@debbugs.gnu.org; Wed, 03 Apr 2019 12:42:44 -0400 Original-Received: from mail-ed1-f66.google.com ([209.85.208.66]:38566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBiyG-0004mG-28 for 35123@debbugs.gnu.org; Wed, 03 Apr 2019 12:42:42 -0400 Original-Received: by mail-ed1-f66.google.com with SMTP id q14so15520771edr.5 for <35123@debbugs.gnu.org>; Wed, 03 Apr 2019 09:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dG7j7KRtro/cPbK7+H3l6afzK1n0EIc8dzzoTKPe8FA=; b=0iep/W+49nl9fYhSlQ4K+ykMSWjVZrGZSGkd8E/aXPFHElDt9vtSpYSn2wht8eJIbZ fNj6nO9i02EClRfLEvjFWTbhgOFoE+3uVkA0/+nBEyLGafS4IEPhPYeLSudp7AJMenkG b2zWy3WHeUkrc1/jGXm38qmHesISMSxXkjEEzBsP6PhHiZ0r+z+B/00RvmFhG9lRvKLc fuv0neUILKBlzBpZ+VAN/4YjCDJ4A1/rj3d//Tld9Fjwz5xiC3sy036WoOqzQzjDVZcV DZCMSqHCw1aGhwDirpby93+YHkL0YBvhBKoHqSr+aqIMmRQ7h+M8Ot108hvzA2wWQXbt IlNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dG7j7KRtro/cPbK7+H3l6afzK1n0EIc8dzzoTKPe8FA=; b=f9oG0aXCBTzRYPnWiNyIB+fz5eDDecslrGclQgW/+G/SHvG90HJhm07ll+u4B+CwIR vD5NZP3Q+cCnaHRpGrjyU3BnaVWIwAhbt2FABUV+WqlmGrSa54nwWlygU8J7UG7zKcdE 2eyq1FGQTff2yKe1Tq03kDuZHOMh4PQY0M9AKVCqCRIHyXI3ypjgpo/PaQXrISa1ETxs JzhkRCZWJLQv7XmeldnMkW6MzX3IP5yLHzjVoadT7RYYwEvgJTOi5BPlTHgISYYeDAMh O0tlN7Sqi59Olwy9qL1W0pNOcyHtx701MwHwtFCL5n1iDHfhDCdaJ3dBb3oUriwMqXGs kYXQ== X-Gm-Message-State: APjAAAVOM3rCIj1rc00xd5FXl3H+mQxsKHNW6aR0axj93dh/UXIo1jrC JZe0q8GAezEse8xLk+drJNlDSg== X-Google-Smtp-Source: APXvYqyu1sNbeXraakBQEM7+bF4V7g3Pe+7xC0BBTO7mzAO0HGuoNS927G7IjYYmso+pc7JjOBJ6Uw== X-Received: by 2002:a05:6402:144d:: with SMTP id d13mr442921edx.64.1554309753131; Wed, 03 Apr 2019 09:42:33 -0700 (PDT) Original-Received: from localhost ([134.226.214.248]) by smtp.gmail.com with ESMTPSA id z35sm5052258edd.81.2019.04.03.09.42.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Apr 2019 09:42:32 -0700 (PDT) In-Reply-To: <87wokbb18k.fsf@gmail.com> (Alex Branham's message of "Wed, 03 Apr 2019 09:40:59 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157126 Archived-At: Alex Branham writes: > diff --git a/.dir-locals.el b/.dir-locals.el > index 9cd39920c2..506edfcf73 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -1,6 +1,7 @@ > ((nil . ((tab-width . 8) > (sentence-end-double-space . t) > - (fill-column . 70))) > + (fill-column . 70) > + (bug-reference-url-format . "https://debbugs.gnu.org/%s"))) > (c-mode . ((c-file-style . "GNU") > (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK")) > (electric-quote-comment . nil) > @@ -12,7 +13,6 @@ > (log-edit-setup-add-author . t))) > (change-log-mode . ((add-log-time-zone-rule . t) > (fill-column . 74) > - (bug-reference-url-format . "https://debbugs.gnu.org/%s") > (mode . bug-reference))) > (diff-mode . ((mode . whitespace))) > (emacs-lisp-mode . ((indent-tabs-mode . nil) While you're at it, why not also change (mode . bug-reference) to (eval . (bug-reference-mode)) as per the recommended way to enable minor modes described in (info "(emacs) Specifying File Variables")? Apart from that, and FWIW, LGTM. Thanks, -- Basil