From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Issue with ns_color_defined makeIndex argument Date: Thu, 11 Apr 2019 10:05:28 -0600 Message-ID: <87lg0gttmf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110542"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Alan Third To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 11 18:05:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEcCt-000SYH-Uf for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 18:05:44 +0200 Original-Received: from localhost ([127.0.0.1]:51593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEcCs-0001CP-Vk for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 12:05:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEcCh-0001BF-MU for emacs-devel@gnu.org; Thu, 11 Apr 2019 12:05:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEcCg-0002MW-PH for emacs-devel@gnu.org; Thu, 11 Apr 2019 12:05:31 -0400 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:32806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEcCg-0002MG-CX for emacs-devel@gnu.org; Thu, 11 Apr 2019 12:05:30 -0400 Original-Received: by mail-pl1-x62d.google.com with SMTP id t16so3644685plo.0 for ; Thu, 11 Apr 2019 09:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:user-agent:mime-version; bh=z/2aYMPg5MKy7uHQZ3WOp2zIpT8ZwAXAcCm3xjPRoss=; b=IRP1u0aSPgv3dx4WA+ySJh20LfqFcYQuk72dH/6ZbyknrXgc0xsTZlgwCdNsrH9mti umYP/GGWJqnqTj1aRMvvDJF0IsXckUG7BQlePO4rUNl6IwjzMyWf0vhbFh6/Votf3f93 gxi0iwIR2pEpi7QsrxRnESWTj0+tGjkiOI0IPYXxX6MhgedE7gzXdtmC12ZwIenXftcP mykCA77kvHE5asDEaRIs52tTxg6cGPQkNZgpKZpkFMN7DqGWC8wB4clVcZhWwefUQFxk Dl8pYQT8pAw7Mgivjly19MvFAa8kZ1MVATw+mBgGq+6F7CFzjLhLScMrPRTaPQiJMMYs ZTeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :mime-version; bh=z/2aYMPg5MKy7uHQZ3WOp2zIpT8ZwAXAcCm3xjPRoss=; b=FKwUYuY7Cx5q0oTwpK+b233SbtoKQMRhC5ynHqUhG/LKX/A/8Kg3DhA6Q02WstZmIs ajEO7FdMItVR0dMxtFkkc4pqZ9fPLdSWzffPUIgPeyojcx+NlFWvD8HfzaQPXchfqK9p P335YpMrvN05hYStEqpks7wLOEQHHaS1Cu+5woxY+sqy+v2YVV5PaSO2e70Q1HUlE/pe BbmsMqYOC9eAI4qBsdNaul5wzKX1hmgCoRN4KpDGufkP5gEOlRs58IIVo/hChFc4tOe9 otN19bDH6y1Rfoa5NeKVk1x+G0VNrz91bGfgTtYBggJWmc+e/UtoTNgyhE+tH74Z5xRg 7hAw== X-Gm-Message-State: APjAAAV6cO9OVsPo2xc8OakA3JjBQAVk9CSLWycYW1xL765U1dwpvkzS TEKbiOtqMbxMWpUg4l6xzAzjqawi X-Google-Smtp-Source: APXvYqx+xrDFcOzq10DAEqr0M3POBrkD51dCb1F7rQiHhGItT768O+lWxt28PVng8dQm2OTWVWMkkA== X-Received: by 2002:a17:902:441:: with SMTP id 59mr21482479ple.242.1554998729132; Thu, 11 Apr 2019 09:05:29 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id z7sm19779319pgh.81.2019.04.11.09.05.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 09:05:28 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235297 Archived-At: I'm currently generalizing some window system-specific code into terminal hooks, but I've run into an issue regarding ns_color_defined. In image.c when HAVE_NS is defined, x_defined_color is defined to be: ns_defined_color (f, name, color_def, alloc, 0) But in xfaces.c, defined_color calls ns_defined_color as follows: ns_defined_color (f, color_name, color_def, alloc, true); My intention is to remove defined_color in xfaces.c and the #define x_defined_color calls in image.c and to replace each call with: FRAME_TERMINAL (f)->defined_color_hook (f, color_name, color_def, alloc) The issue here is that the calls in image.c have makeIndex as 0, and the calls in xfaces.c as true; is this the intended behaviour? If so, does anyone have any ideas to rectify this besides adding an extra argument that non-NS window systems just ignore? I'd rather avoid doing that.