From: Alex <agrambot@gmail.com>
To: emacs-devel@gnu.org
Cc: Alan Third <alan@idiocy.org>
Subject: Issue with ns_color_defined makeIndex argument
Date: Thu, 11 Apr 2019 10:05:28 -0600 [thread overview]
Message-ID: <87lg0gttmf.fsf@gmail.com> (raw)
I'm currently generalizing some window system-specific code into
terminal hooks, but I've run into an issue regarding ns_color_defined.
In image.c when HAVE_NS is defined, x_defined_color is defined to be:
ns_defined_color (f, name, color_def, alloc, 0)
But in xfaces.c, defined_color calls ns_defined_color as follows:
ns_defined_color (f, color_name, color_def, alloc, true);
My intention is to remove defined_color in xfaces.c and the #define
x_defined_color calls in image.c and to replace each call with:
FRAME_TERMINAL (f)->defined_color_hook (f, color_name, color_def, alloc)
The issue here is that the calls in image.c have makeIndex as 0, and the
calls in xfaces.c as true; is this the intended behaviour?
If so, does anyone have any ideas to rectify this besides adding an
extra argument that non-NS window systems just ignore? I'd rather avoid
doing that.
next reply other threads:[~2019-04-11 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:05 Alex [this message]
2019-04-13 10:09 ` Issue with ns_color_defined makeIndex argument Alan Third
2019-04-13 16:16 ` Alex Gramiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg0gttmf.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.