From: Michael Albinus <michael.albinus@gmx.de>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 35362@debbugs.gnu.org
Subject: bug#35362: 26.2; [debbugs.el] Automate commit -> debbugs flow (posting patches, closing bugs after pushing)
Date: Thu, 25 Apr 2019 14:16:33 +0200 [thread overview]
Message-ID: <87lfzy8ela.fsf@gmx.de> (raw)
In-Reply-To: <87pnparg0j.fsf@gmail.com> (Noam Postavsky's message of "Wed, 24 Apr 2019 22:10:52 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
Hi Noam,
I believe your patch is almost OK, so let's apply it. But of course, I
still have some few remarks :-)
>>> Invoke the command @code{debbugs-gnu-pick-commits} and press
>>
>> Should we give this command a key binding?
>
> Maybe, but then the question is what map to bind it in. Is it okay to
> start adding things into vc-git-log-view-mode-map?
Yep. Maybe we bind "c" for it, because other candidates (d/D/p/P) seem
to be bound already.
Furthermore, we might mention debbugs-gnu-pick-commits in the
;;; Commentary section of debbugs-gnu.el.
>> I don't understand (yet), how the description of this variable helps. Is
>> the user expected to change the value herself, somehow? Otherwise, we
>> might to keep this description out.
>
> The idea is you can add entries that can work with other packages, e.g.,
> magit.
OK, this part I don't understand yet (I'm not a magit user, for
example). But I don't mind.
> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> + (add-hook 'message-send-actions
> + (lambda () (remhash bugid debbugs-cache-data))
> + nil t)))
Do we need to declare message-send-actions?
> +(defun debbugs-gnus-jump-to-bug (bugid)
> + "Display buffer associated with BUGID with `pop-to-buffer'.
> +Use `gnus-read-ephemeral-emacs-bug-group' instead if there is no such buffer."
Maybe you could add at least a FIXME for the lack of rmail support.
> +(defun debbugs-gnu--git-insert (&rest args)
> + "Insert output of running git with ARGS.
> +Throws error if git returns non-zero. Uses `vc-git-program'."
Don't mention vc-git-program.
> + (unless (eql 0 (apply #'vc-git--call '(t t) args))
Declare vc-git--call.
> +(defun debbugs-gnu--git-remote-info ()
> + "Return (REMOTE . INFO-ALIST)."
Say, that REMOTE is a string, which must be matched by REMOTE-REGEXP of
debbugs-gnu-git-remote-info-alist. Refer to the docstring of that user option.
> + (dir (make-temp-file (format "patches-for-bug%d-" bugnum) t))
I'm curious: Why a trailing "-" in the buffer name?
> + (deldir (lambda ()
> + (delete-directory dir t)
> + (remove-hook 'message-exit-actions deldir t)
Do we need to declare message-exit-actions?
> + (dolist (patch (directory-files dir t "\\`[^.]"))
> + (mml-attach-file patch type "patch" disposition))
Do we need to declare mml-attach-file?
> +`debbugs-gnu-pick-commits' and jump to read bug in prepration for
Typo.
> --- a/packages/debbugs/debbugs-ug.texi
> +++ b/packages/debbugs/debbugs-ug.texi
> +The string inserted to describe an announced commit is controlled by
> +the variable @code{debbugs-gnu-commit-description-format}, it is a
It is a user option.
> +subitem is appended to the commit description. By default this
> +variable is configured for the GNU Emacs and GNU ELPA repositories,
That's also a user option.
Best regards, Michael.
next prev parent reply other threads:[~2019-04-25 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 14:56 bug#35362: 26.2; [debbugs.el] Automate commit -> debbugs flow (posting patches, closing bugs after pushing) Noam Postavsky
2019-04-21 15:23 ` Noam Postavsky
2019-04-21 15:27 ` Noam Postavsky
2019-04-21 19:58 ` Michael Albinus
2019-04-22 19:42 ` Noam Postavsky
2019-04-23 8:03 ` Michael Albinus
2019-04-25 2:10 ` Noam Postavsky
2019-04-25 12:16 ` Michael Albinus [this message]
2019-04-27 13:44 ` Noam Postavsky
2019-04-28 7:53 ` Michael Albinus
2019-05-06 12:17 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfzy8ela.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=35362@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.