From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32897: 26.1; nxml-mode indentation Date: Thu, 09 May 2019 07:45:12 -0400 Message-ID: <87lfzfkg1j.fsf@gmail.com> References: <87pnphvqlv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50537"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Stefan Monnier , 32897@debbugs.gnu.org To: David Carlisle Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 09 13:46:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOhV5-000D0F-2l for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 13:46:11 +0200 Original-Received: from localhost ([127.0.0.1]:52829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOhV4-00011F-3V for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 07:46:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOhUx-0000yq-0H for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:46:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOhUw-0002Dj-1k for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49510) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOhUv-0002De-Ur for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOhUv-000381-Nl for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 11:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32897-submit@debbugs.gnu.org id=B32897.15574023239412 (code B ref 32897); Thu, 09 May 2019 11:46:01 +0000 Original-Received: (at 32897) by debbugs.gnu.org; 9 May 2019 11:45:23 +0000 Original-Received: from localhost ([127.0.0.1]:34821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOhUI-0002RG-ET for submit@debbugs.gnu.org; Thu, 09 May 2019 07:45:22 -0400 Original-Received: from mail-it1-f175.google.com ([209.85.166.175]:35015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOhUF-0002JO-Hc; Thu, 09 May 2019 07:45:20 -0400 Original-Received: by mail-it1-f175.google.com with SMTP id u186so2849891ith.0; Thu, 09 May 2019 04:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=w9fyLpy58FUHvoYYzLgog7eBYLRw7WctIB3skmPOQeo=; b=u2XuI7dVNzjAVT8sN0hNTsnxjREcB0vUNYwRmJK1QIun7yMMSZ7NGwPa123tWdNTmi sA4kDzEqy5RY2dfmWCEuxDQ8nqfgoc0oIuSqQNBjXcoFrzXxgGW6qxzIaK5oB647vKgj U7IAId2wbltJHiztIw29AN88+FdH1UcYVjznRor6FBiwYGPoGs+0lcMkXpaKGtjst6Oe aO9U/vMi6gy5s/ZxxyIbLJWgmCERpyapfj319ePD/M2kRDfDjMEGpAtBZSlewWr0NApy jixbcCnCTxcvlfv1EtrBuhokYTyGW4OTrzJUbGZ34uRwXeQq1jyXuM1AVATe90p3bMpp zYTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=w9fyLpy58FUHvoYYzLgog7eBYLRw7WctIB3skmPOQeo=; b=gAvrZuk13DUDA8re1IhJTNRsSHpx4U0ZlK9B+opghhNW/pefyNNIDIZLoyPb/S0uK4 iJ0q4ihsQEx4cwOSS+3h0BVlh5gUvGg+yIpyhcOC679770y+iPCf51Gp9NEXRqBGx0vY g5fvOKFHBttnrzYPS3IvHWIfJGweoUAJuwBHFsGsah0tDpE5NNLMbT3DBrdZQl2D3orw R5btg51Dr9aGLWmmYCztCyCPLTeqq6EU7w9sWU0AGXysImpR+BYrqWNBvp4cTwFS2xMv 4Q/CstBJj5NVM3ZQeptnPPpe/IRFZ9piQnK58Q/xRr/IpCZf1MfZ+KcXLdJCEsimTSG8 8rhA== X-Gm-Message-State: APjAAAURi9yqlZGF3EZzQEm1Jj6/hPIoPxPEWWNDigsoew6QSwfCm4VA mR+HittAug0AmXWND0830LexLivO X-Google-Smtp-Source: APXvYqxXmWlN0gNq3tG4h5t6Na8aIre40ljbVRczQTjQHce1nX6VFkGqZEUYvXiuAQG8sF8RAQkQag== X-Received: by 2002:a24:6292:: with SMTP id d140mr2370814itc.12.1557402313865; Thu, 09 May 2019 04:45:13 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id t191sm932017itt.17.2019.05.09.04.45.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 May 2019 04:45:13 -0700 (PDT) In-Reply-To: <87pnphvqlv.fsf@gmail.com> (Noam Postavsky's message of "Fri, 19 Apr 2019 13:42:36 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158978 Archived-At: tags 32897 fixed close 32897 26.3 quit Noam Postavsky writes: >> Also it does not show a visual newline for #10, even when other numeric >> references to printable characters do display the character, which was >> the desired behaviour. > > I assume this was changed by [1: 930f8e8377]. I guess can just special > case newline, it's the only character that has this problem that I can > think of. This would be for emacs-26 since it's a regression. > Subject: [PATCH] Disable extra display of in nxml-mode (Bug#32897) > > * lisp/nxml/nxml-mode.el (nxml-char-ref-display-extra): Don't put > display for the newline, it makes the indentation look wrong. > + (when (and ;; Displaying literal newline is unhelpful. > + (not eql n ?\n) > + nxml-char-ref-extra-display) Added missing parens, and pushed to emacs-26. e4cde42657 2019-05-09T06:42:40-04:00 "Disable extra display of in nxml-mode (Bug#32897)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e4cde42657f8f91f795e6b7041dc50b896dc468d