From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Tue, 21 May 2019 23:12:14 +0300 Organization: LINKOV.NET Message-ID: <87lfyzy3c1.fsf@mail.linkov.net> References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114193"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 35624@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 21 22:21:52 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTBGi-000TM4-2z for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 May 2019 22:21:52 +0200 Original-Received: from localhost ([127.0.0.1]:59021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTBGY-0005Z2-2g for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 May 2019 16:21:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTBFw-0005Fr-00 for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 16:21:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTBFv-0007nR-0h for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 16:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTBFu-0007me-T9 for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 16:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTBFu-0001ft-Ot for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 16:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 May 2019 20:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.15584700276346 (code B ref 35624); Tue, 21 May 2019 20:21:02 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 21 May 2019 20:20:27 +0000 Original-Received: from localhost ([127.0.0.1]:41074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTBFL-0001eD-5k for submit@debbugs.gnu.org; Tue, 21 May 2019 16:20:27 -0400 Original-Received: from ostrich.birch.relay.mailchannels.net ([23.83.209.138]:4824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTBFI-0001dw-Fg for 35624@debbugs.gnu.org; Tue, 21 May 2019 16:20:25 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5695722CE9; Tue, 21 May 2019 20:20:23 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (100-96-38-8.trex.outbound.svc.cluster.local [100.96.38.8]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D886D22CDB; Tue, 21 May 2019 20:20:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 21 May 2019 20:20:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Dime-Macabre: 501514f50806f9f6_1558470022416_2668904642 X-MC-Loop-Signature: 1558470022416:119843146 X-MC-Ingress-Time: 1558470022416 Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id AA08680469; Tue, 21 May 2019 13:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=BX2GP6WdKHEFsWyDpAVpvkkVzKM=; b= r9Xl88hZzqhwbO49KbsFd+ZbwJg+tVjm9gbym/NPykrBHxXGIO2bw6jk0cHpcRXd 3R8OriEpDuxgsv5VvCJWp7YwJyrMiOSqF7vrenOlV1lCDOMQu1GX3TWytEdZXnq7 clCZA6gtzOIeDyj/TyFJFI6kSrGJ9nmRG26tLt9sRqY= Original-Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 1C9AE8045C; Tue, 21 May 2019 13:20:10 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 In-Reply-To: <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> (Dmitry Gutov's message of "Tue, 21 May 2019 02:29:00 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddgudeglecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159618 Archived-At: > One alternative which I have already mentioned is to make a different > command handle this. E.g. 'C-u d' might diff workfile and the revision at > point. This actually seems faster that go to bob and create the > necessary region. This is not self-evident and not WYSIWYG as the visual region selection is. > For the main purpose of the log buffer, the empty first line is weird > (saying "working revision" would be just as weird). vc-rcs and vc-cvs inserts 12-lines long header in the log buffer and no one complained for several decades :) OTOH, when recently Android developers changed the position of the clock from the right side of the screen to the left, billions of users silently adapted their habits to the new position without protests :( > I could maybe live with it if were 1-character tall (and in a terminal, > maybe invisible until you move point to it) It's already 1-character tall. But it you meant 1-pixel tall, then I agree it's a good idea (like 1-pixel line is already used in log-edit.el): diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index b6feb3b8d1..238b04929b 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1018,7 +1018,7 @@ vc-git-print-log ;; read-only. (let ((inhibit-read-only t)) (with-current-buffer buffer - (insert "\n") + (insert (propertize "\n" 'font-lock-face '(:height 0.1))) (apply 'vc-git-command buffer 'async files (append