From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Tue, 28 May 2019 14:17:12 -0700 Message-ID: <87lfyqth2f.fsf@ericabrahamsen.net> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87h8t69d7b.fsf@ericabrahamsen.net> <87609lcbip.fsf@ericabrahamsen.net> <87bmjcc2rh.fsf@ericabrahamsen.net> <874lp4aije.fsf@ericabrahamsen.net> <83po7pwlgs.fsf@gnu.org> <87lgib4z2o.fsf@ericabrahamsen.net> <87wp1rcz21.fsf@users.sourceforge.net> <87mv2jkaap.fsf@killashandra.ballybran.fr> <87wp1nsk52.fsf@killashandra.ballybran.fr> <87y3m2jl3b.fsf@ericabrahamsen.net> <871shf30fn.fsf@killashandra.ballybran.fr> <87woz2qdyo.fsf@ericabrahamsen.net> <877er23rev.fsf@killashandra.ballybran.fr> <87sh9qufb2.fsf@ericabrahamsen.net> <87muzx52l7.fsf@killashandra.ballybran.fr> <87h8q4uc8x.fsf@ericabrahamsen.net> <87v9xv79nf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="151554"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: jwiegley@gmail.com, 29220@debbugs.gnu.org, monnier@iro.umontreal.ca, Pierre =?UTF-8?Q?T=C3=A9choueyres?= To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 28 23:18:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVjU5-000dK7-Sh for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 May 2019 23:18:14 +0200 Original-Received: from localhost ([127.0.0.1]:42868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVjU4-0000qV-Ri for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 May 2019 17:18:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVjTy-0000qD-00 for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 17:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVjTu-0000pB-N7 for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 17:18:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVjTu-0000om-CA for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 17:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVjTu-0000nY-6i for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 17:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2019 21:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs Original-Received: via spool by 29220-submit@debbugs.gnu.org id=B29220.15590782442048 (code B ref 29220); Tue, 28 May 2019 21:18:02 +0000 Original-Received: (at 29220) by debbugs.gnu.org; 28 May 2019 21:17:24 +0000 Original-Received: from localhost ([127.0.0.1]:57417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVjTH-0000Wk-VE for submit@debbugs.gnu.org; Tue, 28 May 2019 17:17:24 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:54086 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVjTF-0000Qs-0N for 29220@debbugs.gnu.org; Tue, 28 May 2019 17:17:21 -0400 Original-Received: from localhost (50-251-205-17-static.hfc.comcastbusiness.net [50.251.205.17]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 9222EFA01E; Tue, 28 May 2019 21:17:14 +0000 (UTC) In-Reply-To: <87v9xv79nf.fsf@gmail.com> (Noam Postavsky's message of "Mon, 27 May 2019 19:36:04 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159868 Archived-At: On 05/27/19 19:36 PM, Noam Postavsky wrote: > Eric Abrahamsen writes: > >>>> Bah, this is annoyingly difficult -- thank you for trying it out. I >>>> suppose one terrible heuristic would be if the errors were different >>>> between emacs-25, emacs-26, and fix/eieio-persistent. Would you mind >>>> sending me the error output, in case anything jumps out at me? >>>> >>> Hope this could help you. >> >> Thanks. They all end in "Corrupt object on disk", which is an >> eieio-persist problem. I'll keep working on this. > > So, I think it would be nice to have this fixed for 26.3. It sounds > like the fix you're working on is too risky to have on a release branch > regardless of its current status, so here's a patch which makes eieio > objects use symbols as type tags, when eieio-backward-compatibility is > non-nil. Folks who want the record-with-circular-references as type > tags can still get that by setting eieio-backward-compatibility to nil. I agree that everything I came up with is too shaky for a release branch. I haven't tried your solution, but it looks simple enough. Despite much help from many people, this problem ultimately defeated me. I was trying to come up with a universal solution that would work for any object, and after a couple of months had something that worked for restoring objects, but then realized that it wouldn't work for saving them. Whereupon I deflated like a cheap balloon. This is just beyond my skills right now. Eric