From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36591: 26.2; Term's pager seems broken Date: Tue, 23 Jul 2019 09:53:37 -0400 Message-ID: <87lfwox3fi.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172729"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: 36591@debbugs.gnu.org To: Adam Bliss Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 23 15:54:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpvF2-000ili-Ft for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 15:54:08 +0200 Original-Received: from localhost ([::1]:42662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpvF1-0007FQ-35 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 09:54:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40343) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpvEx-0007Al-FR for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 09:54:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpvEw-0006P0-IO for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 09:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpvEw-0006On-CU for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 09:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpvEw-0007OZ-7Y for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 09:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2019 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36591 X-GNU-PR-Package: emacs Original-Received: via spool by 36591-submit@debbugs.gnu.org id=B36591.156389002528398 (code B ref 36591); Tue, 23 Jul 2019 13:54:02 +0000 Original-Received: (at 36591) by debbugs.gnu.org; 23 Jul 2019 13:53:45 +0000 Original-Received: from localhost ([127.0.0.1]:34168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpvEf-0007Nx-LA for submit@debbugs.gnu.org; Tue, 23 Jul 2019 09:53:45 -0400 Original-Received: from mail-io1-f48.google.com ([209.85.166.48]:37367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpvEe-0007Nm-Ic for 36591@debbugs.gnu.org; Tue, 23 Jul 2019 09:53:45 -0400 Original-Received: by mail-io1-f48.google.com with SMTP id q22so81953240iog.4 for <36591@debbugs.gnu.org>; Tue, 23 Jul 2019 06:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Zj7VnKU6+k8CELV+G23ZWLeyUxc9BBRJhsm3hMw9zjM=; b=vWJI6AmcIqu0867RIhsChKfkNbqPeFLut4aBSrq4gLtRxUbstBjEHp+TXIF7ujeIlD QtDKMb26c6s3ZJ2w6tgoKw1jOJ2m+z017CtRT77/4gquBHnpxpradUOODp1q8Sk0FJ7e 05N51lj8nURGj5AEDnVsDB/zMcw8qBj8WL/6P/FXrJKF4Mcvdh9jEC2F8uNce2jVKhsb 86KOvLN9J2orQttN4DKL6NOM+44OxNPuO71lDrhzkNb55e7AqrHagdoE27bpvVh645CW Piq3l+R5KGxkVaEODGk9ol/G+/kNuQi0cMBBO7n/nYXfrg1+W5WY0XN3f4pRHwnrEu/N RAVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Zj7VnKU6+k8CELV+G23ZWLeyUxc9BBRJhsm3hMw9zjM=; b=ZstckhiersVVweGQSPqL9fVuclb0yVaK9z7OsH3QIpDfxdFp1DZJJMPzJibIInvBr0 9dEDGhcVLnxPGF5ivUx5rc68BnQS7MS0bATC7OulbgEbVXN4dRx/5zPoDeZWtKHRD7Su RB4XyIK9Q/WPtFAjVlg0pW+sRr0y46ByBqf9dMK0CMtvl5uRdILN57/oknHc5ABJoF6i iD3KFBG4KVFM+N4MuQPKKG+4bdt28JGjsXLq5iiUXZPU9PSlNfhCCmCJ2EY5TfBbP4K1 lIAFx1idgxDo8m+qfzunOVFEdEEMZtQFS7pbX9zd3lZh48yylGnUWNbnMpS+h9d64l02 FcNQ== X-Gm-Message-State: APjAAAVkLI3mM1Pn+oG8BvC15B3yst+9C6+RIH5sAcKiSgoCQO13GvlT NdzXMh08e43RwiFqtOnxdngwB9rM X-Google-Smtp-Source: APXvYqxtqSpD3NIIthYpN+LUdiOotlpFKELbVOT/Z4RbcBhr762fAPo3GxjcAElmw78S6KGjAVHilw== X-Received: by 2002:a5e:9304:: with SMTP id k4mr73198626iom.206.1563890018709; Tue, 23 Jul 2019 06:53:38 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u17sm40435349iob.57.2019.07.23.06.53.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jul 2019 06:53:37 -0700 (PDT) In-Reply-To: (Adam Bliss's message of "Wed, 10 Jul 2019 20:06:00 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163629 Archived-At: Adam Bliss writes: > I hope that this is helpful in tracking down the bug. Thanks for doing this, it was very helpful. That commit looks like a pretty innocent refactoring, but it actually reverses the sense of the EQ (p->filter, Qt) check, because the pset_filter call is moved earlier. So the bug can be fixed by adding a single '!'. Eli, any chance of having this fix in the release branch? --- i/src/process.c +++ w/src/process.c @@ -1230,7 +1230,7 @@ set_process_filter_masks (struct Lisp_Process *p) { if (EQ (p->filter, Qt) && !EQ (p->status, Qlisten)) delete_read_fd (p->infd); - else if (EQ (p->filter, Qt) + else if (!EQ (p->filter, Qt) /* Network or serial process not stopped: */ && !EQ (p->command, Qt)) add_process_read_fd (p->infd);