From: Noam Postavsky <npostavs@gmail.com>
To: Adam Bliss <abliss@gmail.com>
Cc: 36591@debbugs.gnu.org
Subject: bug#36591: 26.2; Term's pager seems broken
Date: Tue, 23 Jul 2019 09:53:37 -0400 [thread overview]
Message-ID: <87lfwox3fi.fsf@gmail.com> (raw)
In-Reply-To: <CAEAeJWzif9br3sHyM3r5PwO1y2mzxy9SHCBXqG-gKV2ebE-nAw@mail.gmail.com> (Adam Bliss's message of "Wed, 10 Jul 2019 20:06:00 -0400")
Adam Bliss <abliss@gmail.com> writes:
> I hope that this is helpful in tracking down the bug.
Thanks for doing this, it was very helpful. That commit looks like a
pretty innocent refactoring, but it actually reverses the sense of the
EQ (p->filter, Qt) check, because the pset_filter call is moved earlier.
So the bug can be fixed by adding a single '!'. Eli, any chance of
having this fix in the release branch?
--- i/src/process.c
+++ w/src/process.c
@@ -1230,7 +1230,7 @@ set_process_filter_masks (struct Lisp_Process *p)
{
if (EQ (p->filter, Qt) && !EQ (p->status, Qlisten))
delete_read_fd (p->infd);
- else if (EQ (p->filter, Qt)
+ else if (!EQ (p->filter, Qt)
/* Network or serial process not stopped: */
&& !EQ (p->command, Qt))
add_process_read_fd (p->infd);
next prev parent reply other threads:[~2019-07-23 13:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 0:06 bug#36591: 26.2; Term's pager seems broken Adam Bliss
2019-07-23 13:53 ` Noam Postavsky [this message]
2019-07-23 17:40 ` Eli Zaretskii
2019-07-23 22:33 ` Adam Bliss
2019-07-24 2:07 ` Noam Postavsky
2019-07-24 15:07 ` Eli Zaretskii
2019-07-25 0:55 ` Noam Postavsky
2019-07-25 10:02 ` Lars Ingebrigtsen
2019-07-25 13:01 ` Eli Zaretskii
2019-07-25 16:58 ` Lars Ingebrigtsen
2019-07-25 13:01 ` Noam Postavsky
2019-07-25 17:01 ` Lars Ingebrigtsen
2019-07-25 17:28 ` Noam Postavsky
2019-07-25 17:44 ` Lars Ingebrigtsen
2019-07-25 17:57 ` Noam Postavsky
2019-07-25 13:11 ` Eli Zaretskii
2019-07-25 22:38 ` Noam Postavsky
2020-08-21 12:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfwox3fi.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36591@debbugs.gnu.org \
--cc=abliss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.