From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b75fb81 1/4: Extend button.el to take callback data Date: Thu, 01 Aug 2019 15:11:16 +0300 Message-ID: <87lfwd2ihn.fsf@tcd.ie> References: <20190730132507.32385.70681@vcs0.savannah.gnu.org> <20190730132509.77D2820C0A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="373"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 01 14:11:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ht9w5-0018AT-73 for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 14:11:57 +0200 Original-Received: from localhost ([::1]:55392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht9w3-000300-Ot for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 08:11:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42258) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht9vf-0002zr-5s for emacs-devel@gnu.org; Thu, 01 Aug 2019 08:11:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ht9vd-00057N-Sr for emacs-devel@gnu.org; Thu, 01 Aug 2019 08:11:31 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:43169) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ht9vd-000577-DE for emacs-devel@gnu.org; Thu, 01 Aug 2019 08:11:29 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id p13so73296484wru.10 for ; Thu, 01 Aug 2019 05:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wNxf8cmpnS7SU9JuxRceWecfo6aoPWAvRaOm29Sk640=; b=MLuBOYxVPVhJnwP7N5HcP4wLlg5Eink9ZeRa/aK2PbqSDyouw8Rm/HVckiU6Be/bm7 7R81f199hMQMqu8mh/lknTGlmpUY/kP/O8R9DqtxN3wCVmq3fGFYskzs1qeV96WudIhy awcTYd8657HQcPGzH+0ifMkZL2U6PEu9o2h2a2v1bctL10775sWrahxLJjUjBloGUQJP 5Jb7mMCedW7aK6UXM6X/5Dje5wNqy5fhw3Z3+GesYx3whxpHvvpKL1x0bMGfhd5MevBR Qhjjar30JWZm89RMwCrXRAaps1KGq3MJi24JFoet/9m0+SIIZSIhGPyDa3Dy8Mg15GWd rSYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wNxf8cmpnS7SU9JuxRceWecfo6aoPWAvRaOm29Sk640=; b=aWC+NAzvxKR+AYMMzhFJNCAt+jx1WU0iZtHAtyylVipFyAtBo3O/hdRHAUNVJUhQH0 ICF/+aWvbQyXPUxWPF0uMyvIX7WLyOZ8dyk4/XUd1KztT1AnZNP1z3KvdHNJWiOfVL0M uD6XCA8YuwjrxKkLzPClsZJHB0CFyh4tcBrJXHA/IbfPp+8NEVF/TsvdtPn/IKWhi46F VGhIQkcFY9eZosAwSsi544++w5V0U9V+rO8aVay7advClxV4VQapiEUEjVO09fig+ZXJ MymJV4mQEt9Kz61gnumO/3D6L1yWOrvhCAKfOW6P5T0pl5SIYDohb787gn1rpfnvUlJk rmkg== X-Gm-Message-State: APjAAAULkjVo8LmIq1Zk8c17F/+Ry57uAPywVIQe1hwnqx7L3dWnVlXQ XRCn/V7NHd0DPIo5sXnmdqujJMFSclFOVA== X-Google-Smtp-Source: APXvYqynJ0kYVCfbFVjOZ+Z+UqdmoSGN3UCVVVT8CNDf6OSUzkHlg7azoMsWyV2nB+3++IbxQANcIg== X-Received: by 2002:a5d:4206:: with SMTP id n6mr73470090wrq.110.1564661487568; Thu, 01 Aug 2019 05:11:27 -0700 (PDT) Original-Received: from localhost (adsl-131.91.140.89.tellas.gr. [91.140.89.131]) by smtp.gmail.com with ESMTPSA id k9sm851499wrd.46.2019.08.01.05.11.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 01 Aug 2019 05:11:26 -0700 (PDT) In-Reply-To: <20190730132509.77D2820C0A@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 30 Jul 2019 09:25:09 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239092 Archived-At: larsi@gnus.org (Lars Ingebrigtsen) writes: > branch: master > commit b75fb81e362b8afbf37da0d2480676269430694c > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Extend button.el to take callback data Can you please explain the rationale behind this? I'm not sure it's a good idea: 1. Arbitrary data can already be associated with buttons and retrieved in their action functions using button-get, button-put, and on button creation with make{,-text}-button et al. 2. AIUI this is a potentially backward-incompatible change, as existing action functions, which expect to receive a button, may now receive the value of the button-data property instead. So at first glance I'm not convinced the minor convenience of not having to manually (button-get button 'button-data) or similar in the action function is worth messing with the pre-existent and cleaner API. Am I missing something? Thanks, -- Basil