From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36707: [PATCH] Signal user-error on duplicate package refresh Date: Thu, 08 Aug 2019 20:16:13 -0400 Message-ID: <87lfw3qjle.fsf@gmail.com> References: <874l3j11v4.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="218219"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: 36707@debbugs.gnu.org, Stefan Kangas To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 09 02:17:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvsak-000ufz-Mx for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Aug 2019 02:17:10 +0200 Original-Received: from localhost ([::1]:55782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvsaj-0003sa-EP for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Aug 2019 20:17:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57336) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvsad-0003sS-Hr for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 20:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvsac-0000Yn-QY for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 20:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33097) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvsac-0000Yg-Mc for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 20:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvsac-0001PR-H9 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 20:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Aug 2019 00:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36707-submit@debbugs.gnu.org id=B36707.15653097853592 (code B ref 36707); Fri, 09 Aug 2019 00:17:02 +0000 Original-Received: (at 36707) by debbugs.gnu.org; 9 Aug 2019 00:16:25 +0000 Original-Received: from localhost ([127.0.0.1]:41918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvsZy-0000tO-7P for submit@debbugs.gnu.org; Thu, 08 Aug 2019 20:16:25 -0400 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:34898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvsZw-0000nb-BR for 36707@debbugs.gnu.org; Thu, 08 Aug 2019 20:16:20 -0400 Original-Received: by mail-ot1-f45.google.com with SMTP id j19so49334422otq.2 for <36707@debbugs.gnu.org>; Thu, 08 Aug 2019 17:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mDUGP9CkhnL8Rj4j7+KscAZxTuh7N2bfbvmGGcCV6WE=; b=o3o+0b0gL9fp9KccJd/6TM3LEwstW9Uxue0PALzP8QAUOIaFtxh24Y5tJ/Qtv7iEVe s2fG0eQW8gAKd8QUI/FU3ZtggLcrz46rxvbZIoFdMQwpZvUd1GXT6bVEgTdCegKFCsoH /x4TfoDag97rfUrWN+bP2nxE/IM/xUrauInDBIEQIGCcU5OjoJz8qJuhBAcfdsTSGXDC W8Qyg5MuK19XqOisXcqVrl3phM8/InG2USVwnugitn76akEOwFW5KHdOVETPFwjl8bZ9 OerVAmrEzThZ780qG8u2toRmWsP5w26h+KSQ7jTrcgM+v/0YQ4+t0/XggbsLgmGY9vuP BdBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mDUGP9CkhnL8Rj4j7+KscAZxTuh7N2bfbvmGGcCV6WE=; b=eVKfx8eTqMwFcBgddTjXS3ecE4IQ7H4F4n+Tmy3t2+gsFWKXGQ9HSN0Y8d5elgLZXO HtG8xe1ONcAdluc7Wo/Yev6/Q1QZjX2NyBd2mmBuA5u7sdfGpoTX1QEeA/iFW7Xe3CJ7 9Yk8NXNjlGbgKawk9KbLkuNKcENhwavQ40d4eG+ldcE2r6UPrKraieC5cFFb+tzCaBWK /DK1Z7x01MLMgNur+FR6nU/tS54qhsLGJb6gnIDLRj+Dj+uLcFqT8DN3bZak7ZuU8HX4 BK0r6JytrTYR3Q0wezI2N26CXKGKVQVOvA4MQ/61VF8z/rVtn4OZWM6oZ476KS6u3QJo QkYw== X-Gm-Message-State: APjAAAUQF74iAoapBsjYTwuPHYYrGO5tRtD8XWcWnMalu7HO1hIQvogY X9u2AF1bCYVnQ0ECggjPwpsPmCGr X-Google-Smtp-Source: APXvYqxH1CTe6oEMjKiGYv9yLg/+l5AV0xD7Z1XwuYiWGYtBSpiEc3DOOPBgZhcfJV4yUnb5sx0mew== X-Received: by 2002:a6b:ed01:: with SMTP id n1mr18380076iog.255.1565309774612; Thu, 08 Aug 2019 17:16:14 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id p63sm93207186iof.45.2019.08.08.17.16.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 17:16:14 -0700 (PDT) In-Reply-To: <874l3j11v4.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 18 Jul 2019 22:14:55 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164788 Archived-At: "Basil L. Contovounesios" writes: > Stefan Kangas writes: > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times >> it will try to initiate more refreshes even if the first one has not finished >> yet. This is unnecessary and potentially confusing. >> >> This patch makes it check if there is already an refresh in progress and signal >> a user-error if there is one. > > Would it not be possible/better to discard the existing refresh and > start a new one, instead of signalling an error? This would help > e.g. when a refresh hangs for whatever reason. Not sure if it's better, supposing the user is hitting "r" repeatedly, that just interrupts the pending refreshes, preventing any progress. I would expect hanging to be cancelled by a timeout anyway.