From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable Date: Sat, 28 Sep 2019 19:47:17 +0200 Message-ID: <87lfu8uxcq.fsf@gnus.org> References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> <87woua8xf5.fsf@pointsman.de> <87muv5n841.fsf@tromey.com> <87d0hruonx.fsf@pointsman.de> <874l0xmftl.fsf@pointsman.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="163330"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 23565@debbugs.gnu.org, Tom Tromey To: Rolf Ade Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 28 19:48:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEGpK-000gIW-R5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 19:48:14 +0200 Original-Received: from localhost ([::1]:34092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEGpJ-0002Gz-EK for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 13:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39143) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEGpA-0002Et-Ma for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 13:48:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEGp9-0008RZ-IZ for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 13:48:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEGp8-0008RF-BJ for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 13:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEGp8-0005LM-8l for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 13:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2019 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 23565-submit@debbugs.gnu.org id=B23565.156969284620498 (code B ref 23565); Sat, 28 Sep 2019 17:48:02 +0000 Original-Received: (at 23565) by debbugs.gnu.org; 28 Sep 2019 17:47:26 +0000 Original-Received: from localhost ([127.0.0.1]:51142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEGoX-0005KY-U4 for submit@debbugs.gnu.org; Sat, 28 Sep 2019 13:47:26 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEGoU-0005KN-4i for 23565@debbugs.gnu.org; Sat, 28 Sep 2019 13:47:24 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEGoP-0004yJ-TK; Sat, 28 Sep 2019 19:47:20 +0200 In-Reply-To: <874l0xmftl.fsf@pointsman.de> (Rolf Ade's message of "Sat, 28 Sep 2019 02:20:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167503 Archived-At: Rolf Ade writes: > * lisp/progmodes/tcl.el (tcl-calculate-indent) Fall back to old > indentation method for tcl code at the start of the buffer before the > first word matching an element out of tcl-proc-list. > > Copyright-paperwork-exempt: yes > > diff --git a/lisp/progmodes/tcl.el b/lisp/progmodes/tcl.el > index 0fd3d6d1bf..db97230480 100644 > --- a/lisp/progmodes/tcl.el > +++ b/lisp/progmodes/tcl.el > @@ -817,7 +817,9 @@ tcl-calculate-indent > found-next-line) > (if parse-start > (goto-char parse-start) > - (beginning-of-defun)) > + (if (not (beginning-of-defun)) > + (let ((beginning-of-defun-function nil)) > + (beginning-of-defun)))) Hm... This does fix the indentation issue, but I wonder whether tcl-beginning-of-defun-function should be fixed instead so that the movement commands work better? I don't use TCL, but the problem is that top-level (outside of functions) that tcl-beginning-of-defun-function doesn't go to the start of forms like: if {$argc != 0} { puts stderr "usage: $argv0" } But what should beginning-of-defun do outside of functions? It's not documented in the doc string of that function... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no