From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#39994: 27.0.90; Broken image-converter probe for imagemagick Date: Mon, 16 Mar 2020 02:23:44 +0200 Organization: LINKOV.NET Message-ID: <87lfo19mgf.fsf@mail.linkov.net> References: <87d09mpexq.fsf@mail.linkov.net> <877dztopns.fsf@gnus.org> <87mu8p9mjj.fsf@mail.linkov.net> <87fteb16x0.fsf@gnus.org> <87wo7ma3n7.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="2498"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 39994@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 16 03:04:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jDf7V-0000Wz-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Mar 2020 03:04:45 +0100 Original-Received: from localhost ([::1]:33212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDf7T-0006Fg-VV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Mar 2020 22:04:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38896) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDdhl-0007t1-4a for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 20:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDdhj-0008LT-Ro for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 20:34:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDdhj-0008K4-KN for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 20:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDdhj-0005cK-HJ for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 20:34:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Mar 2020 00:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 39994-submit@debbugs.gnu.org id=B39994.158431881221521 (code B ref 39994); Mon, 16 Mar 2020 00:34:03 +0000 Original-Received: (at 39994) by debbugs.gnu.org; 16 Mar 2020 00:33:32 +0000 Original-Received: from localhost ([127.0.0.1]:35848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDdhE-0005b3-Ct for submit@debbugs.gnu.org; Sun, 15 Mar 2020 20:33:32 -0400 Original-Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:14042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDdhB-0005as-V4 for 39994@debbugs.gnu.org; Sun, 15 Mar 2020 20:33:30 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BD1EC400FE5; Mon, 16 Mar 2020 00:33:27 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a100.g.dreamhost.com (100-96-1-27.trex.outbound.svc.cluster.local [100.96.1.27]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 42E53400F88; Mon, 16 Mar 2020 00:33:27 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a100.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 16 Mar 2020 00:33:27 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Tangy-Oafish: 255717e559ab225d_1584318807547_2734622231 X-MC-Loop-Signature: 1584318807547:2035523667 X-MC-Ingress-Time: 1584318807546 Original-Received: from pdx1-sub0-mail-a100.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a100.g.dreamhost.com (Postfix) with ESMTP id 07816B2178; Sun, 15 Mar 2020 17:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=IRJAis NkxETRWWt0L336qi2Y3KI=; b=wnpbiDaBVBOEGO+Qo+XxHEv39tm+YmtNp51Hhi 206Tx3UaKWni84Ai7EDdyyssEWk57+h3sz6BkkksR3HLfw6BH80wKHwHQFFMSVmK 2zmcmeTs+dj6YoJjwLdec0HeInMoWAjUIWUfyg/qFEJ8w4MViwJ5puKgmbMXwJY8 57Kqk= Original-Received: from mail.jurta.org (m91-129-107-65.cust.tele2.ee [91.129.107.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a100.g.dreamhost.com (Postfix) with ESMTPSA id 70B49B2179; Sun, 15 Mar 2020 17:33:19 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a100 In-Reply-To: <87wo7ma3n7.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 15 Mar 2020 02:00:12 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrudefuddgleduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtjedrieehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdejrdeihedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrgh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177402 Archived-At: Since now it's pretest time, I gave it more testing, and found more probl= ems: 1. AFAIR one of the goals for creating image-converter.el was to handle such rare image formats as WEBP, but I tried to open a webp file, and image-converter failed because it doesn't recognize WEBP. There is no WEBP mentioned in the output of "identify -list format". After installing `apt-get install webp`, another command "identify -list delegate" reports its support with: Delegate Command -----------------------------------------------------------------------= -------- webp =3D> "dwebp' -pam '%i' -o '%o" png<=3D webp "cwebp' -quiet %Q '%i' -o '%o" 2. After adding manually webp to image-converter-regexp, there is another problem: image-converter--convert-magick calls the command with (apply #'call-process (car command) nil t nil where the arg 't' means to mix standard error output with ordinary output= , but ImageMagick outputs some info messages to stderr, e.g.: Decoded /tmp/magick-20114vaPD-fxUjRW4. Dimensions: 320 x 214 . Format: = lossy. Now saving... Saved file /tmp/magick-20114h1Jh0D04beDR thus breaking the image output. 3. Visiting an image file from an archive signals the error Cannot display image: (IMAGE-FORMAT should be a symbol like =E2=80=98im= age/png=E2=80=99) 4. Exif fails to visit images with the error: Cannot display image: (sequencep 122) Shouldn't exif code be called with ignore-errors, so its errors won't affect the image displaying? Test case: exif --output=3Dblackz.jpg --tag=3DArtist --ifd=3D0 --set-value=3D'z' t= est/data/image/black.jpg Exif fails to handle ASCII field values whose length is less than 4. In the above example the length of the 'Artist' field is 1 ('z').