From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: Optimise 'while' bodies for effect
Date: Fri, 17 Apr 2020 11:41:34 +0100 [thread overview]
Message-ID: <87lfmu4co1.fsf@tcd.ie> (raw)
In-Reply-To: <B35C3341-22D1-474B-8113-12F10D62B6B9@acm.org> ("Mattias Engdegård"'s message of "Thu, 16 Apr 2020 12:52:31 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> 14 apr. 2020 kl. 17.05 skrev Basil L. Contovounesios <contovob@tcd.ie>:
>
>> ;; XXX: need to find a better way to do the following
>> (while (not (file-readable-p tmpfile))
>> ;; do something, otherwise this will be optimized away
>> - (format "org-babel-screen: File not readable yet."))
>> + (sit-for 0.1))
>
> This can only be an improvement!
Thanks, pushed to master.
Fix effect-free warning in ob-screen.el while loop
7f1dae114d 2020-04-17 11:38:25 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7f1dae114dffbf4bdec60e38ada4eb0673cfb4e2
--
Basil
prev parent reply other threads:[~2020-04-17 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 16:59 Optimise 'while' bodies for effect Mattias Engdegård
2019-12-26 18:19 ` Stefan Monnier
2019-12-26 18:46 ` Mattias Engdegård
2020-04-14 15:05 ` Basil L. Contovounesios
2020-04-16 10:52 ` Mattias Engdegård
2020-04-17 10:41 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfmu4co1.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.