From: Juri Linkov <juri@linkov.net>
To: David Ponce <da_vid@orange.fr>
Cc: emacs-devel@gnu.org
Subject: Re: create-image and find-image consistency
Date: Mon, 20 Apr 2020 02:24:14 +0300 [thread overview]
Message-ID: <87lfmrvz35.fsf@mail.linkov.net> (raw)
In-Reply-To: <3a9c34ae-8052-d634-78c3-e83a2f6b6624@orange.fr> (David Ponce's message of "Wed, 15 Apr 2020 10:48:52 +0200")
> I propose the below patch to have `find-image' use `create-image' in order to get
> consistent results from both functions. Another advantage of using `create-image' is
> that it is no longer necessary to provide the :type property to `find-image'.
> The correct type is determined by `create-image' with the proper default scaling.
>
> Here is the result of previous example with patched `find-image':
>
> (find-image '((:file "[EMACS-DIR]/etc/images/icons/hicolor/scalable/apps/emacs.svg")))
> ==> (image :type svg :file "[EMACS-DIR]/etc/images/icons/hicolor/scalable/apps/emacs.svg" :scale 1.2)
>
> Please eventually consider this enhancement to Emacs, if it makes sense.
I haven't tested it yet, but it makes sense indeed.
next prev parent reply other threads:[~2020-04-19 23:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:48 create-image and find-image consistency David Ponce
2020-04-19 23:24 ` Juri Linkov [this message]
2020-04-30 5:08 ` Lars Ingebrigtsen
2020-04-30 9:24 ` bug#40978: " David Ponce
2020-04-30 13:39 ` Clément Pit-Claudel
2020-04-30 22:05 ` bug#40978: " Lars Ingebrigtsen
2022-06-20 9:38 ` bug#40978: bug#47039: 27.1; find-image ignores image-scaling-factor Lars Ingebrigtsen
2020-04-30 8:53 ` bug#40978: 28.0.50; create-image and find-image consistency David Ponce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfmrvz35.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=da_vid@orange.fr \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.