bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link from org-plus-contrib

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link from org-plus-contrib

[Sébastien Miquel]

With a minimal init.el to allow (use-package org :ensure 
org-plus-contrib), and once it is natively compiled, calling 
org-insert-link doesn't prompt for a description.

Describe function reports that org-insert-link is native compiled Lisp 
function in ‘ol.el’.

Manually evaluating the source in ol.el restores the correct behaviour: 
org-insert-link prompts for a link, then for a description.

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Daniel Kraus]

Hi,

I just want to mention that I experience a similar problem with `org-refile`.
Where I get: `org-get-outline-path: Invalid function: org-with-wide-buffer`

After evaluating `org-refile.el` manually it works fine.

BTW, thanks for the native-comp branch. Only running it since a few days
but very happy so far. I run it with 200+ packages and the only "bug"
I found so far is this and a missing eieio require in the jupyter
package where it worked before native compilation but not after.
Adding that require fixed it: https://github.com/dzop/emacs-jupyter/pull/248

Thanks,
  Daniel

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Andrea Corallo]

Daniel Kraus <daniel@kraus.my> writes:

> Hi,
>
> I just want to mention that I experience a similar problem with `org-refile`.
> Where I get: `org-get-outline-path: Invalid function: org-with-wide-buffer`
>
> After evaluating `org-refile.el` manually it works fine.
>
> BTW, thanks for the native-comp branch. Only running it since a few days
> but very happy so far. I run it with 200+ packages and the only "bug"
> I found so far is this and a missing eieio require in the jupyter
> package where it worked before native compilation but not after.
> Adding that require fixed it: https://github.com/dzop/emacs-jupyter/pull/248
>
> Thanks,
>   Daniel

Hi Daniel,

thanks happy to hear works well for you!

I'll get to look into this bug presumably this weekend.

Thanks

  Andrea

-- 
akrl@sdf.org

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Andrea Corallo]

Daniel Kraus <daniel@kraus.my> writes:

> Hi,
>
> I just want to mention that I experience a similar problem with `org-refile`.
> Where I get: `org-get-outline-path: Invalid function: org-with-wide-buffer`
>
> After evaluating `org-refile.el` manually it works fine.

Hi Daniel,

taking a look I think your bug was already signaled here as a
native-comp bug but in reality is a bug in the org side and as so has
been reported there.

https://lists.gnu.org/archive/html/emacs-orgmode/2020-04/msg00095.html

I think is still not solved tho taking a quick look to the repo.

  Andrea

-- 
akrl@sdf.org

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Daniel Kraus]

Hi!

Andrea Corallo <akrl@sdf.org> writes:

> taking a look I think your bug was already signaled here as a
> native-comp bug

I'm not subscribed to this bug mailing list and somehow I have
a hard time browsing and searching with debbugs to look for already
existing bugs :(

> but in reality is a bug in the org side and as so has been
> reported there.
> https://lists.gnu.org/archive/html/emacs-orgmode/2020-04/msg00095.html

Thanks for investigating. Now I can patch my local version until
upstream is fixed.

I just found one more broken package. https://github.com/silex/docker.el/

Like with jupyter and org, I guess this is simply an error
in the package and not your code but I can't figure out what's wrong.

When calling any docker function (like `docker-containers`)
it calls this macro https://github.com/silex/docker.el/blob/08745207332d940130a2357eb5c5e00fd88bd6af/docker-utils.el#L102-L107
and then I get:

docker-run-docker: Invalid function: docker-utils-with-sudo

Thank you very much,
  Daniel

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Andrea Corallo]

Daniel Kraus <daniel@kraus.my> writes:

> Hi!
>
> Andrea Corallo <akrl@sdf.org> writes:
>
>> taking a look I think your bug was already signaled here as a
>> native-comp bug
>
> I'm not subscribed to this bug mailing list and somehow I have
> a hard time browsing and searching with debbugs to look for already
> existing bugs :(

Sure was not a remark :)

>> but in reality is a bug in the org side and as so has been
>> reported there.
>> https://lists.gnu.org/archive/html/emacs-orgmode/2020-04/msg00095.html
>
> Thanks for investigating. Now I can patch my local version until
> upstream is fixed.
>
> I just found one more broken package. https://github.com/silex/docker.el/
>
> Like with jupyter and org, I guess this is simply an error
> in the package and not your code but I can't figure out what's wrong.
>
> When calling any docker function (like `docker-containers`)
> it calls this macro https://github.com/silex/docker.el/blob/08745207332d940130a2357eb5c5e00fd88bd6af/docker-utils.el#L102-L107
> and then I get:
>
> docker-run-docker: Invalid function: docker-utils-with-sudo
>
> Thank you very much,
>   Daniel

To a quick look I think in docker-core.el is missing a
'(require 'docker-utils)'.

Thanks

  Andrea


-- 
akrl@sdf.org

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Daniel Kraus]

Hi Andrea!

Just wanted to give a quick update that the org bug is
fixed for me with the latest org from the org git repo.


Unrelated, I just noticed that `treemacs-magit.el` from the
treemacs package is not compiling. The log output is:

libgccjit.so: error: gcc_jit_block_end_with_jump: adding to terminated block: bb_29 (already terminated by: if (local19 == d_reloc[(long long)36]) goto bb_27; else goto bb_27;)
Internal native compiler error: "/home/daniel/.emacs.d/lib/treemacs/src/extra/treemacs-magit.el", "failing to compile function", treemacs-magit--simple-git-mode-update, "gcc_jit_block_end_with_jump: adding to terminated block: bb_29 (already terminated by: if (local19 == d_reloc[(long long)36]) goto bb_27; else goto bb_27;)"

Not sure if I should create a new issue for it.

Thanks,
  Daniel

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link

[Andrea Corallo]

Daniel Kraus <daniel@kraus.my> writes:

> Hi Andrea!
>
> Just wanted to give a quick update that the org bug is
> fixed for me with the latest org from the org git repo.
>

Hi Daniel,

> Unrelated, I just noticed that `treemacs-magit.el` from the
> treemacs package is not compiling. The log output is:
>
> libgccjit.so: error: gcc_jit_block_end_with_jump: adding to terminated
> block: bb_29 (already terminated by: if (local19 == d_reloc[(long
> long)36]) goto bb_27; else goto bb_27;)
> Internal native compiler error:
> "/home/daniel/.emacs.d/lib/treemacs/src/extra/treemacs-magit.el",
> "failing to compile function", treemacs-magit--simple-git-mode-update,
> "gcc_jit_block_end_with_jump: adding to terminated block: bb_29
> (already terminated by: if (local19 == d_reloc[(long long)36]) goto
> bb_27; else goto bb_27;)"
>
> Not sure if I should create a new issue for it.

Yes please.

Thanks for the feedback.

  Andrea

-- 
akrl@sdf.org

bug#40694: 28.0.50; [feature/native-comp] Different behavior of org-insert-link from org-plus-contrib

[Andrea Corallo]

Sébastien Miquel <sebastien.miquel@posteo.eu> writes:

> With a minimal init.el to allow (use-package org :ensure
> org-plus-contrib), and once it is natively compiled, calling
> org-insert-link doesn't prompt for a description.
>
> Describe function reports that org-insert-link is native compiled Lisp
> function in ‘ol.el’.
>
> Manually evaluating the source in ol.el restores the correct
> behaviour: org-insert-link prompts for a link, then for a description.

Hi Sébastien,

3ac3ba22be fix the issue for me, closing.

Thanks for the bug report.

  Andrea

-- 
akrl@sdf.org