From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: stardiviner Newsgroups: gmane.emacs.bugs Subject: bug#40564: 28.0.50; sql.el should add support PostgreSQL alias "postgresql" of "postgres" Date: Mon, 27 Apr 2020 13:08:08 +0800 Message-ID: <87lfmhv7lz.fsf@gmail.com> References: <87zhbh33ui.fsf@gmail.com> <871roabdq2.fsf@stefankangas.se> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="122603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4; emacs 28.0.50 Cc: "numbchild@gmail.com" , Michael Mauger , Michael Mauger , "40564@debbugs.gnu.org" <40564@debbugs.gnu.org> To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 27 07:09:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSw1E-000VoN-8Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Apr 2020 07:09:24 +0200 Original-Received: from localhost ([::1]:53108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSw1C-0000Rq-Vb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Apr 2020 01:09:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52374) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSw12-0000RZ-GU for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 01:09:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSw0s-0005en-An for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 01:09:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSw0r-0005eD-V6 for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 01:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSw0r-0003Zp-Nd for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 01:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: stardiviner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2020 05:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40564 X-GNU-PR-Package: emacs Original-Received: via spool by 40564-submit@debbugs.gnu.org id=B40564.158796411413713 (code B ref 40564); Mon, 27 Apr 2020 05:09:01 +0000 Original-Received: (at 40564) by debbugs.gnu.org; 27 Apr 2020 05:08:34 +0000 Original-Received: from localhost ([127.0.0.1]:35343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSw0Q-0003Z7-Hl for submit@debbugs.gnu.org; Mon, 27 Apr 2020 01:08:34 -0400 Original-Received: from [183.249.128.92] (port=9650 helo=dark.localdomain) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSw0I-0003Yb-DK for 40564@debbugs.gnu.org; Mon, 27 Apr 2020 01:08:32 -0400 Original-Received: by dark.localdomain (Postfix, from userid 1000) id 9805A2413BC; Mon, 27 Apr 2020 13:08:11 +0800 (HKT) In-reply-to: <871roabdq2.fsf@stefankangas.se> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179125 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Stefan Kangas writes: > Michael Mauger writes: > >> * Based on my understanding of this issue, I believe that this not a feature appropriate >> for sql-mode, but rather it represents a weakness in the EJC->SQL mapping. Sql.el has >> used `postgres' as the identifier of the PostgreSQL since the first commit in '99. It >> was exposed as a user visible variable in `sql-product-alist' in 2003. EJC is using a >> heuristic that may work for other products, but it definitely won't work for all (It is >> broken for EJC's `sqlserver', which is `ms' in sql.el). Though I can accept first copy identify to add a new one identity "postgresql" as solution. Actually, not just in package ejc-sql has this identify problem, in Org Mode's ob-sql.el also has this problem. And I think "postgres" is an historical name. (Maybe I misunderstand it https://en.wikipedia.org/wiki/PostgreSQL) Here is a related discussion thread archive (https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00347.html). This two extensions are used by me. Maybe there are other extensions. Anyway, I can accept maintainer's solution, in private email communication, I have already accepted, just I also send email here at that time. So I express my thought. > > Thanks. If I understand correctly, the recommendation is to report > this to the ejc developers. > > Does that mean that this bug should be closed as "wontfix"? Or is > there anything more to do here? > > Best regards, > Stefan Kangas -----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6maLgUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsPiyggAz0upYIt9FEE53hPcNiQe3aZgshOI qDZn87Gp8v3g6dqIfcmPYy1z2LgOwwm2IDwk+4VDuWXO1H28axEqw/PDoFfVKGgq ZiOCQc0RGgKL1rBw6c3QlHHQvpt//ZpgfhbHK9pQVuJV68dUt/0kftEmvCmDBCPf fqwnxPSbXQEo8xaplrGDx3NsRGSz+LTHxZt/oH71TcvPtSBFD2KHO8QtDmGvyQUB cJCtF75r1NuHILwYUCVSPe8v2CAFrMTFNPzXD/JB6FDf7cAaOkuxQP4VeMARHQ7h RAQwwz9Hdhu8A1d0ev9yl7/TAIJcpbVYhPhNdR6yuup9+LJpR1vNBOLJzQ== =d+3/ -----END PGP SIGNATURE-----