all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug] error on RET in read-only buffer with org-return-follows-link set to t
@ 2020-05-14 19:40 Gregor Zattler
  2020-05-14 21:28 ` Nicolas Goaziou
  2020-05-14 21:32 ` Kévin Le Gouguec
  0 siblings, 2 replies; 6+ messages in thread
From: Gregor Zattler @ 2020-05-14 19:40 UTC (permalink / raw)
  To: emacs-orgmode, Kévin Le Gouguec

Dear Kévin, org-mode developers, 

with `org-return-follows-link` set to `t` in a read-only
buffer I now get a `Buffer is read-only: #<buffer
notmuch-startpage.org>` error when pressing ENTER/RETURN
with point on an org-mode link.

This used to work (opening the org-mode link) till

d3e6b58004997c5a9eeea82f96723c0f74480ab8 is the first bad commit
commit d3e6b58004997c5a9eeea82f96723c0f74480ab8
Author: Kévin Le Gouguec <kevin.legouguec@gmail.com>
Date:   Tue May 5 19:01:07 2020 +0200

    Make RET and C-j obey `electric-indent-mode'

    * lisp/org-compat.el (org-return-indent): Deprecate this command.
    * lisp/org-keys.el (org-mode-map): Rebind C-j to a command emulating
    `electric-newline-and-maybe-indent'.
    * lisp/org.el (org-cdlatex-environment-indent): Stop using the now
    obsolete function.
    (org--newline): New helper function.
    (org-return): Use it to transparently handle `electric-indent-mode'.
    (org-return-and-maybe-indent): New command to emulate
    `electric-newline-and-maybe-indent' while taking care of Org special
    cases (tables, links, timestamps).
    * testing/lisp/test-org.el (test-org/with-electric-indent,
    test-org/without-electric-indent): New tests.
    * testing/org-test.el (org-test-with-minor-mode): New helper to set a
    minor mode to a specific state, and reset it afterward.

:040000 040000 85f261b701133d4be047c1a2e8872b25f3e0c7e7 21fe88d69e48ac3d24d233cbf07fe0084cde853e M      etc
:040000 040000 a677d2134361d2b023f252c188aebdeef9826896 4bdbb34abe7eaad343932d33a03c823b2cae0e24 M      lisp
:040000 040000 9ecba96d2748f0e7ff5430ec0fcf8c175875621f f6e7b54445ac19d1b7c59d4d54bd9b4a19126245 M      testing


I use this dozens of times a day and it would be convenient
if it was possible to resurrect the old behaviour.


Thanks for your attention and for developing org-mode,
Gregor 
-- 
 -... --- .-. . -.. ..--.. ...-.-



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-15 13:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-14 19:40 [bug] error on RET in read-only buffer with org-return-follows-link set to t Gregor Zattler
2020-05-14 21:28 ` Nicolas Goaziou
2020-05-14 21:57   ` Kévin Le Gouguec
2020-05-14 22:49     ` Nicolas Goaziou
     [not found]       ` <87a72a6sj6.fsf@nicolasgoaziou.Freitag>
2020-05-15 12:54         ` Gregor Zattler
2020-05-14 21:32 ` Kévin Le Gouguec

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.