From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#41276: Acknowledgement ([PATCH 0/9] Various small improvements to EasyPG) Date: Fri, 15 May 2020 18:56:06 +0200 Message-ID: <87lflt6st5.fsf@bernoul.li> References: <20200514191325.22061-1-jonas@bernoul.li> <87sgg26zpv.fsf@bernoul.li> <83o8qp3bgq.fsf@gnu.org> <87pnb5781d.fsf@bernoul.li> <83wo5d1klq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116438"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41276@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 15 18:57:26 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZdeH-000UAb-MY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 May 2020 18:57:25 +0200 Original-Received: from localhost ([::1]:38084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZdeG-00028a-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 May 2020 12:57:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZddu-00027S-7Z for bug-gnu-emacs@gnu.org; Fri, 15 May 2020 12:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZddt-0000OA-Ud for bug-gnu-emacs@gnu.org; Fri, 15 May 2020 12:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZddt-0007A4-Ty for bug-gnu-emacs@gnu.org; Fri, 15 May 2020 12:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 May 2020 16:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41276-submit@debbugs.gnu.org id=B41276.158956177027443 (code B ref 41276); Fri, 15 May 2020 16:57:01 +0000 Original-Received: (at 41276) by debbugs.gnu.org; 15 May 2020 16:56:10 +0000 Original-Received: from localhost ([127.0.0.1]:38645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZdd4-00078Z-ES for submit@debbugs.gnu.org; Fri, 15 May 2020 12:56:10 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:53882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZdd3-00078R-1b for 41276@debbugs.gnu.org; Fri, 15 May 2020 12:56:09 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 7A05616676; Fri, 15 May 2020 18:56:07 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id nUpDIEcUlN1z; Fri, 15 May 2020 18:56:07 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 0AE0316634; Fri, 15 May 2020 18:56:07 +0200 (CEST) In-Reply-To: <83wo5d1klq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180343 Archived-At: Eli Zaretskii writes: >> From: Jonas Bernoulli >> Cc: 41276@debbugs.gnu.org >> Date: Fri, 15 May 2020 13:27:10 +0200 >> >> Eli Zaretskii writes: >> > A few of the patches in the series don't have commit log messages, >> >> All of the patches do have commit messages. The mail subject field is >> used as the commit message subject line, except that the "[PATCH n/m] " >> has to be removed. > > Right, that's the header line. I meant the part after it, which > mentions the file(s) and the function(s) where the changes are done. I can only see one commit that lacks a commit message body in addition to the commit message summary line. [I am a little confused because while I agree that I failed to follow the conventions and need to fix that, you do talk about multiple commits that have this particular defect while I can see only a single commit, which might potentially have that defect.] The subject of the respective mail is: [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation So the complete commit message becomes: * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Which I though was allowed or even encouraged. From CONTRIBUTE: > - If only a single file is changed, the summary line can be the normal > file first line (starting with the asterisk). Then there is no > individual files section. The wording confuses me. I have decided to interpret it like so (and if that interpretation is correct, then I suggest that CONTRIBUTE is updated to use this wording). > - If only a single file is changed, then the first (and in this case > only) individual file entry can at the same time serve as the summary > line, provided that the entry fits on a single line. In this case > the summary should begin with an asterisk but not end with a period. ------- or on the contrary "and" I added that last sentence because there is some ambiguity that needs to be resolved, namely: > - Start with a single unindented summary line explaining the change; > do not end this line with a period. [...] > - Some commenting rules in the GNU coding standards also apply > to ChangeLog entries: they must be in English, and be complete > sentences starting with a capital and ending with a period (except > the summary line should not end in a period). However I feel it would make more sense for the first rule to override the second. From recent commits it looks like you and some others seem to agree with me: ,---- | ; * src/xdisp.c: Improve the introductory commentary. `---- but Stefan does not: ,---- | * lisp/emacs-lisp/pcase.el (pcase--fgrep): Look inside vectors `----