From: Jonas Bernoulli <jonas@bernoul.li>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41276@debbugs.gnu.org
Subject: bug#41276: Acknowledgement ([PATCH 0/9] Various small improvements to EasyPG)
Date: Fri, 15 May 2020 18:56:06 +0200 [thread overview]
Message-ID: <87lflt6st5.fsf@bernoul.li> (raw)
In-Reply-To: <83wo5d1klq.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Jonas Bernoulli <jonas@bernoul.li>
>> Cc: 41276@debbugs.gnu.org
>> Date: Fri, 15 May 2020 13:27:10 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>> > A few of the patches in the series don't have commit log messages,
>>
>> All of the patches do have commit messages. The mail subject field is
>> used as the commit message subject line, except that the "[PATCH n/m] "
>> has to be removed.
>
> Right, that's the header line. I meant the part after it, which
> mentions the file(s) and the function(s) where the changes are done.
I can only see one commit that lacks a commit message body in addition
to the commit message summary line.
[I am a little confused because while I agree that I failed to follow
the conventions and need to fix that, you do talk about multiple commits
that have this particular defect while I can see only a single commit,
which might potentially have that defect.]
The subject of the respective mail is:
[PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation
So the complete commit message becomes:
* lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation
Which I though was allowed or even encouraged. From CONTRIBUTE:
> - If only a single file is changed, the summary line can be the normal
> file first line (starting with the asterisk). Then there is no
> individual files section.
The wording confuses me. I have decided to interpret it like so (and if
that interpretation is correct, then I suggest that CONTRIBUTE is
updated to use this wording).
> - If only a single file is changed, then the first (and in this case
> only) individual file entry can at the same time serve as the summary
> line, provided that the entry fits on a single line. In this case
> the summary should begin with an asterisk but not end with a period.
-------
or on the contrary "and"
I added that last sentence because there is some ambiguity that needs to
be resolved, namely:
> - Start with a single unindented summary line explaining the change;
> do not end this line with a period. [...]
> - Some commenting rules in the GNU coding standards also apply
> to ChangeLog entries: they must be in English, and be complete
> sentences starting with a capital and ending with a period (except
> the summary line should not end in a period).
However I feel it would make more sense for the first rule to override
the second. From recent commits it looks like you and some others seem
to agree with me:
,----
| ; * src/xdisp.c: Improve the introductory commentary.
`----
but Stefan does not:
,----
| * lisp/emacs-lisp/pcase.el (pcase--fgrep): Look inside vectors
`----
next prev parent reply other threads:[~2020-05-15 16:56 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 19:13 bug#41276: [PATCH 0/9] Various small improvements to EasyPG Jonas Bernoulli
2020-05-14 19:13 ` bug#41272: [PATCH 1/9] * lisp/epa.el (epa-faces): Move definition Jonas Bernoulli
2020-05-14 19:13 ` bug#41269: [PATCH 2/9] Add all epa faces to epa-faces Custom group Jonas Bernoulli
2020-05-14 19:13 ` bug#41270: [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Jonas Bernoulli
2020-05-14 19:13 ` bug#41275: [PATCH 4/9] Split EasyPG libraries into outline sections Jonas Bernoulli
2020-05-14 19:13 ` bug#41277: [PATCH 5/9] Improve and add doc-strings Jonas Bernoulli
2020-05-14 19:13 ` bug#41268: [PATCH 6/9] Drop unnecessary backward compatibility aliases Jonas Bernoulli
2020-05-14 19:13 ` bug#41271: [PATCH 7/9] Cosmetic changes to epa libraries Jonas Bernoulli
2020-05-14 19:13 ` bug#41273: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as parent keymap Jonas Bernoulli
2020-05-14 19:13 ` bug#41274: [PATCH 9/9] * lisp/epa.el (epa-show-key): New command Jonas Bernoulli
2020-06-23 22:57 ` Basil L. Contovounesios
2020-07-07 15:34 ` Jonas Bernoulli
[not found] ` <handler.41276.B.15894836275636.ack@debbugs.gnu.org>
2020-05-14 20:14 ` bug#41276: Acknowledgement ([PATCH 0/9] Various small improvements to EasyPG) Jonas Bernoulli
2020-05-14 22:33 ` Stefan Kangas
2020-05-15 7:26 ` Eli Zaretskii
2020-05-15 11:27 ` Jonas Bernoulli
2020-05-15 11:52 ` Eli Zaretskii
2020-05-15 16:56 ` Jonas Bernoulli [this message]
2020-05-15 17:42 ` Eli Zaretskii
2020-05-15 22:42 ` Jonas Bernoulli
2020-05-16 6:45 ` Eli Zaretskii
2020-05-14 20:16 ` bug#41276: [PATCH 1/9] * lisp/epa.el (epa-faces): Move definition Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 2/9] Add all epa faces to epa-faces Custom group Jonas Bernoulli
2020-05-15 9:32 ` Robert Pluim
2020-06-23 22:57 ` Basil L. Contovounesios
2020-07-07 15:32 ` Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 4/9] Split EasyPG libraries into outline sections Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 5/9] Improve and add doc-strings Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 6/9] Drop unnecessary backward compatibility aliases Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 7/9] Cosmetic changes to epa libraries Jonas Bernoulli
2020-05-14 20:16 ` bug#41276: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as parent keymap Jonas Bernoulli
2020-05-15 7:27 ` Eli Zaretskii
2020-05-14 20:16 ` bug#41276: [PATCH 9/9] * lisp/epa.el (epa-show-key): New command Jonas Bernoulli
2020-05-14 23:04 ` bug#41276: [PATCH 0/9] Various small improvements to EasyPG Stefan Kangas
2020-05-15 9:26 ` Robert Pluim
2020-05-25 1:34 ` Noam Postavsky
2020-07-17 7:30 ` Robert Pluim
2020-07-07 15:47 ` bug#41276: [PATCH v2 0/8] " Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 1/8] * lisp/epa.el (epa-faces): Move definition Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 2/8] Add all epa faces to epa-faces Custom group Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 3/8] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 4/8] Improve and add doc-strings Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 5/8] Drop unnecessary backward compatibility aliases Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 6/8] Cosmetic changes to epa libraries Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 7/8] epa-key-list-mode-map: Use widget-keymap as parent keymap Jonas Bernoulli
2020-07-07 15:47 ` bug#41276: [PATCH v2 8/8] * lisp/epa.el (epa-show-key): New command Jonas Bernoulli
2020-07-07 18:30 ` bug#41276: [PATCH v2 0/8] Various small improvements to EasyPG Eli Zaretskii
2020-07-07 21:09 ` Jonas Bernoulli
2020-07-08 2:29 ` Eli Zaretskii
2020-07-08 12:08 ` Jonas Bernoulli
2020-07-14 18:09 ` Jonas Bernoulli
2020-07-14 18:16 ` Eli Zaretskii
2020-07-14 18:27 ` Jonas Bernoulli
2020-07-14 18:57 ` Eli Zaretskii
2020-07-14 20:20 ` Jonas Bernoulli
2020-07-15 2:22 ` Eli Zaretskii
2020-08-05 19:03 ` bug#41276: [PATCH 0/9] " Lars Ingebrigtsen
2020-08-06 7:22 ` bug#41268: " Jonas Bernoulli
2020-08-06 7:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lflt6st5.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=41276@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.