From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41239@debbugs.gnu.org
Subject: bug#41239: GTK builds crashing in XTread_socket after deleting a frame
Date: Thu, 21 May 2020 21:23:49 -0400 [thread overview]
Message-ID: <87lflklq3e.fsf@gmail.com> (raw)
In-Reply-To: <835zcq7fop.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 May 2020 19:07:50 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Can someone spot where we pass some wrong parameters to GTK/GIO
> functions in xg_prepare_tooltip? Or something we do wrong in
> xg_free_frame_widgets?
The patch below seems to fix it.
--- i/src/gtkutil.c
+++ w/src/gtkutil.c
@@ -1404,10 +1404,15 @@ xg_free_frame_widgets (struct frame *f)
FRAME_X_WINDOW (f) = 0; /* Set to avoid XDestroyWindow in xterm.c */
FRAME_X_RAW_DRAWABLE (f) = 0;
FRAME_GTK_OUTER_WIDGET (f) = 0;
+ if (x->ttip_widget)
+ {
+ /* Remove ttip_lbl from ttip_widget's custom slot before
+ destroying it, to avoid double-free (Bug#41239). */
+ gtk_tooltip_set_custom (x->ttip_widget, NULL);
+ g_object_unref (G_OBJECT (x->ttip_widget));
+ }
if (x->ttip_lbl)
gtk_widget_destroy (x->ttip_lbl);
- if (x->ttip_widget)
- g_object_unref (G_OBJECT (x->ttip_widget));
}
}
next prev parent reply other threads:[~2020-05-22 1:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 17:42 bug#41239: GTK builds crashing in XTread_socket after deleting a frame martin rudalics
2020-05-13 18:04 ` Eli Zaretskii
2020-05-14 7:54 ` martin rudalics
2020-05-14 14:22 ` Eli Zaretskii
2020-05-15 18:07 ` martin rudalics
2020-05-15 18:58 ` Eli Zaretskii
2020-05-16 8:45 ` martin rudalics
2020-05-20 1:50 ` Noam Postavsky
2020-05-20 9:06 ` martin rudalics
2020-05-20 16:07 ` Eli Zaretskii
2020-05-22 1:23 ` Noam Postavsky [this message]
2020-05-22 9:31 ` martin rudalics
2020-05-22 11:05 ` Eli Zaretskii
2020-05-22 11:25 ` Noam Postavsky
2020-05-22 12:08 ` Eli Zaretskii
2020-05-22 12:22 ` Noam Postavsky
2020-05-22 12:37 ` Eli Zaretskii
2020-05-25 0:31 ` Noam Postavsky
2020-09-27 14:43 ` Lars Ingebrigtsen
2020-05-22 13:03 ` martin rudalics
[not found] ` <87d06vl5le.fsf@gmail.com>
[not found] ` <83r1vb189z.fsf@gnu.org>
2020-05-23 12:08 ` Noam Postavsky
2020-05-23 12:38 ` martin rudalics
2020-05-25 0:11 ` Noam Postavsky
2020-05-26 8:03 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lflklq3e.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=41239@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.