From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 1ecd350 2/2: Evaluate some unnecessarily quoted lambdas Date: Sun, 21 Jun 2020 19:08:22 +0100 Message-ID: <87lfkg8f6x.fsf@tcd.ie> References: <20200621124626.3690.70321@vcs0.savannah.gnu.org> <20200621124629.C414420A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="103560"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 21 20:08:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jn4Oo-000QoE-Ky for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 20:08:58 +0200 Original-Received: from localhost ([::1]:52132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn4On-0007pS-MG for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 14:08:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn4OK-0007Qt-Ig for emacs-devel@gnu.org; Sun, 21 Jun 2020 14:08:28 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:34426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jn4OI-0005Qk-He for emacs-devel@gnu.org; Sun, 21 Jun 2020 14:08:28 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id u26so12081823wmn.1 for ; Sun, 21 Jun 2020 11:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZZJaNV5CfZ/K0Op0WjgVtejQtbxHQuk0vzIPtVe7Who=; b=nqaj4KH1j9pvsNlPk0hRvI2qaUdkU75BR58miftr5jlXPTwuvcdiX6ze//yqhCVb4c 07xTWxc8Cj3G74dmAXiW2/XjGHHCNi56Ui6Fx5X+q6JxmqlpNFYYdxZXFHtPRa6pT4jU snSDaBiY2tWU64eaB0C3sBe56ZlMdEnwbmqPGw/F/6jO0LR7BIMIlFbAcU4UHiWnvehL Lk82stS21lI+/ulvnma45/JgIUpQkS5JP7JXZCIqqpko5yPItHmDUekocMeWK8GiU9DA kmQrVOpf9F1HlIjc+IltzsKkAZMHeg+NAGEhnCaO8fovCAdc+xMJegLgHhyzk+3Owrfa TKWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZZJaNV5CfZ/K0Op0WjgVtejQtbxHQuk0vzIPtVe7Who=; b=PWQAKZCMSDvvZrAo+looSJzxhllE6MUBFE6adaB9CWngszr+5sY84CJKjfX78rvFsH Yw2VG0RR3w0+j+lxLZZJ06E7r6b6rPOuiSx/HMdAxduP1t1mppJDpzWStxiANEDmXVPo gVC2RYcTOpaqfvyp1ErWNEOow46CroYjPwdJKT5DWwh5mbnR3VASX6fFb5l80DBbir2/ b0xsLPVpi/gC8dcxj80Qe6/Lt+sKS0P+amKsGPd2fgTuVhgqdPudd+YiNIPkWxGBi8aB UJOhISTBnPugcKQKSucp5YA83PppYgkD7E7qXyRlMl4Sk1+SHkOvTH+IjrfbyYCTyZ7+ D1eA== X-Gm-Message-State: AOAM533Bzc2xtuDXMNi0AAVFxLp6VkUtj3iV9hM01FcW641X6112bdg8 P2pvp6PApxo9lwIgePz/5MOtog== X-Google-Smtp-Source: ABdhPJw5CsBnOliqlkyoZJertO3a9DqC20NEf+HPzkDhf3+NXDZPKTcOQYOWuN8Zny8WYCtbIEoQag== X-Received: by 2002:a1c:4143:: with SMTP id o64mr14014303wma.157.1592762904299; Sun, 21 Jun 2020 11:08:24 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id j14sm14680918wrs.75.2020.06.21.11.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 11:08:23 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 21 Jun 2020 12:18:50 -0400") Received-SPF: none client-ip=2a00:1450:4864:20::330; envelope-from=contovob@tcd.ie; helo=mail-wm1-x330.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252496 Archived-At: Stefan Monnier writes: >> - (lambda-code (byte-compile '(lambda ())))) >> + (lambda-code (byte-compile (lambda ())))) > > I can't believe I'm doing that, but: this hunk is wrong! > > `byte-compile` takes source code as input, not values. It does go to > the trouble of trying to handle the case where we pass it a function > value that's not yet compiled because it's an important use-case in > practice, (Also it's advertised in its docstring.) > but it's better to avoid it since the above means that we'll > first turn '(lambda () ()) into a closure object which `byte-compile` > then has to convert back to something like (lambda () ()). Ah okay. I admit the main reason I thought the hunk was okay is because (byte-compile (lambda ())) and (byte-compile '(lambda ())) produce the same byte-code. Thanks for catching that, now reverted. Revert last change in benchmark.el 0792f8e4f0 2020-06-21 19:01:40 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0792f8e4f0de2328c57d552a5845bdf77265a971 -- Basil