From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior Date: Tue, 04 Aug 2020 10:30:05 +0200 Message-ID: <87lfiuu836.fsf@gnus.org> References: <871rkr7pme.fsf@gmail.com> <87tuxjvk10.fsf@gnu.org> <87k0yfyv1r.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Amin Bandali , emacs-devel@gnu.org To: "Mingde (Matthew) Zeng" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 04 10:38:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2sSe-0002Mi-Rf for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Aug 2020 10:38:16 +0200 Original-Received: from localhost ([::1]:47954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2sSd-0002Vb-TN for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Aug 2020 04:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2sKs-0004RQ-ER for emacs-devel@gnu.org; Tue, 04 Aug 2020 04:30:14 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:42968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2sKq-0000jr-MI; Tue, 04 Aug 2020 04:30:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P4+eUC2LX1NyU3rXZ8VL+bkVuGYl1BcGpsyRKXjbF/k=; b=tDScBkPBJkIdBuqIkwilrlub0t ouj30vK1D79hsgd9zIGYWyN6fenudfFW8HTdH5JxCkavbGo1sjhmI988JE1LOGpY+8Zksb+ktmt+0 ezlolU+C7v7/ngY2CcSW/gQICbrmFgupRk2WnExP0zBHY6Jfm8J4GKPC7BoNBzQakYfI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2sKl-0005h1-5e; Tue, 04 Aug 2020 10:30:09 +0200 In-Reply-To: <87k0yfyv1r.fsf@gmail.com> (Mingde Zeng's message of "Mon, 03 Aug 2020 23:00:32 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253428 Archived-At: "Mingde (Matthew) Zeng" writes: > I had a look at Lars' change, that particular commit simply changes > target to (not target), it is not enough to fix the problem entirely > (as outlined in my commit message). Also, changing to (not target) > technically does avoid this specific problem, but imo it logically > doesn't make sense. When invoking `erc-generate-new-buffer-name`, > target is not an optional parameter and should never be nil, that line > is unnecessary amd therefore removed from my commit. The only usage of that function is (indirectly) from here: (defun erc-open (&optional server port nick full-name connect passwd tgt-list channel process) [...] (buffer (erc-get-buffer-create server port channel)) So I assumed that target could indeed be nil -- especially since that function has always checked whether target is nil or not, only that the previous check was reverse of what it should have been. > I have another question, since I've never contributed to Emacs > directly before, can you tell me is there any way to quickly find out > whether a bug is tracked by GNU bug reports or not? The bug tracker has a search field, if that's what you're asking? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no