From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: vertical fido-mode (new branch) Date: Tue, 25 Aug 2020 21:55:41 +0300 Organization: LINKOV.NET Message-ID: <87lfi2sg36.fsf@mail.linkov.net> References: <13ec44ed-4b54-8d43-590f-709bd813fd01@yandex.ru> <795146083.1708851.1591826041689@mail.yahoo.com> <87y2ouldrr.fsf@mail.linkov.net> <20200819121755.24hgq4gyba2wkt76@Ergus> <87pn7mdqbe.fsf@mail.linkov.net> <20200820103746.6n5op7dtz563k7qm@Ergus> <87pn7llbnb.fsf@mail.linkov.net> <20200821000513.xqdhsdwxm7ov7fkw@Ergus> <87y2m5jlh6.fsf@mail.linkov.net> <20200824190654.d5obxfwyehdgpr4u@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37301"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "emacs-devel@gnu.org" To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 25 21:13:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAeO8-0009ag-RR for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Aug 2020 21:13:44 +0200 Original-Received: from localhost ([::1]:43730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAeO7-0001IN-TX for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Aug 2020 15:13:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAeKR-0005Is-QO for emacs-devel@gnu.org; Tue, 25 Aug 2020 15:09:55 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:58439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAeKP-0004Dk-R5 for emacs-devel@gnu.org; Tue, 25 Aug 2020 15:09:55 -0400 Original-Received: from mail.gandi.net (m91-129-102-47.cust.tele2.ee [91.129.102.47]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id BF38C240007; Tue, 25 Aug 2020 19:09:49 +0000 (UTC) In-Reply-To: <20200824190654.d5obxfwyehdgpr4u@Ergus> (Ergus's message of "Mon, 24 Aug 2020 21:06:54 +0200") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 15:09:50 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254224 Archived-At: > Could you please try the attached patch (where the mode is enabled by default). Cool, now completions navigation is much easier than with anything else. >>Easier can be only one thing: to use arrows and navigation keys to navigate >>completions from the minibuffer. So the main question is on what condition >>to activate these keys (instead of allowing them to search in history)? >> > I enabled the keys only when the *Completions* buffer is shown and the > highlight completions is active. And added a hook to remove the bindings > when minibuffer-hide-completions. Good. > If this patch is too much code for adding in simple and minibuffer, I > would try to make a separate file with a mode. WDYT? Maybe initially this could be a separate package to allow easier experimentation with it. Later when it works well, this could be added to core commands.