From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive Date: Wed, 26 Aug 2020 12:10:55 +0200 Message-ID: <87lfi1emz4.fsf@gmx.net> References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33005"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43003@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 12:12:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAsPu-0008WK-Lr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 12:12:30 +0200 Original-Received: from localhost ([::1]:33706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAsPt-0000d3-Hs for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 06:12:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAsPS-0000bn-Qb for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 06:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAsPS-0004Or-G8 for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 06:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAsPS-0005kq-Bq for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 06:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 10:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43003 X-GNU-PR-Package: emacs Original-Received: via spool by 43003-submit@debbugs.gnu.org id=B43003.159843666321937 (code B ref 43003); Wed, 26 Aug 2020 10:12:02 +0000 Original-Received: (at 43003) by debbugs.gnu.org; 26 Aug 2020 10:11:03 +0000 Original-Received: from localhost ([127.0.0.1]:37451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAsOV-0005hl-ES for submit@debbugs.gnu.org; Wed, 26 Aug 2020 06:11:03 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:52241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAsOU-0005h9-4y for 43003@debbugs.gnu.org; Wed, 26 Aug 2020 06:11:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598436656; bh=06Ye/OHgPJNLAhw0wHmShI91y4s6Vuv33o/yxHSBGQM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Pzugp0MBAofMhXRsbEH04XQwwj5zhBDpPCaX3F0jCpJVbjjhOtnPU0qDfoANVdXvJ T7N95iO9krpkFiv5sk5UYshWOGw5aE6cVPsXK2zlusOugH1tye0TzjJ8PuU/dAFE1D lmD3wdssyzFsui8uckYXzls1W3Gd9NPY3KJHPbOI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([84.61.246.117]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8ofE-1keB4Y07zK-015o7g; Wed, 26 Aug 2020 12:10:56 +0200 In-Reply-To: <878se4dy9u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 24 Aug 2020 14:27:41 +0200") X-Provags-ID: V03:K1:XCQPOhXHRuZyGsiQsRfhaPZ6j5n2HjrTrclVv2bwt02ip/fNi5Q dNueg/v41pQeBUAxXn/7MFcfRdHS6CegBiykNvD7hfgM5ngVWuByxSzQtzzLVIVvGrk6+cj 67OIOA/SJos6LbfdxSrMdkf0GyNgmZuzbAoal0t7D1i9V19vDvF/6ZrQc9eIL8u2KN944Q1 MasqR4qNuIe8mbR4ocPCQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:jcAMOPiEFf4=:bHvg27xAYPHV0FX07Qj3K5 yaEjfx/Ib7iAk7CWGOO9OvKGMwNmi2QZxrURxTSo5j+XS0JsC1f2Czx8E2moYxc5iAPUKLS0P zm6R+gtvdL9ohpw36u9+tWNT6YTAVVAPCeAl/yWaOoBwAUU9shCqZH9raMo3RBkykd8+lZVkh 6Gw4au1+rNhQWC69cvo609W/BnikEGEV5lj5blQpf2hSva/sCn77YO6cNV7ZaiK1a9fgUXNcq P8t8xuVJ4ZGVG/1ia5kHVsqYCNv8biMf8HiPTjVt67/TDFCSBBtYP3li+h9M07BybbTobTSYJ o2kvQvZT7YKwW4edsTSvA/ule/pwq9oX3kpEwYu26+1fD7tGPRgttue1e19CfiJSC0iHPjqEx apt8TUMG7xzGKdtdD7Y45PYKFWZwKBvNs5bPLAFSNoBM6E2yrfNnBgst9ujsZnnO1Bbm0Wcwr dZ6YgXrJNbeqYN21A59qLIMSsdLBrSJ4ZC3JncgMHZXwDXtwPgQeHvMLDlZ2oXKUs9429dZv0 K23M3bj0y/HCkBGchadntAedbVCGz59FCJv58XoD/6btYbgfJzf/V+4Lx4ppS6H4A5WgEZsCz Z5VKt6n2BvL+VTVHvS0WvM7GfWzYJd2xP6yqHtQ1O39bGfpu+TZJJuShjorGWKxgBAWEfAEkw VVAasPaXjo7Bv/fdmi1zvI8ubzndE8C/AtwcBqErpMQr2ZOPGYWXHFVnutymZwhRz7R9nLEtH 4kABEnTmBOxZV0Ga7LB6LsAlSwB7J4Wb/DgKvykh8LWD5gli9NYh0uJYVb/mi4x3rNtwqi4/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186412 Archived-At: --=-=-= Content-Type: text/plain On Mon, 24 Aug 2020 14:27:41 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> So this bug report is basically a plea to change the default value of >> comint-password-prompt-regexp to be the same as that of >> eshell-password-prompt-regexp. Or is there a good reason not to do >> this? > > The difference is that the former looks for something like "enter" > before something like "password:", while the latter is just looking for > variations of "password:"? > > My guess would be that the latter would have more false positives... > but you'd think those would be pretty rare. I can't imagine many people > having shells with prompts like "Type your user name here but definitely > not your password:". > > So I think replacing the former with the latter might work, but comint > is very old code, so perhaps it supports older shells better here... The minimal change to fix my use case is to add the carriage return character as an alternative to comint-password-prompt-regexp, as in the attached patch. If even that is too risky, I'll just stick with a local fix. Steve --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable Content-Description: comint-password-prompt-regexp patch diff --git a/lisp/comint.el b/lisp/comint.el index 092902d865..b6098f449d 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -365,7 +365,7 @@ comint-process-echoes ;; See ert test `comint-test-password-regexp'. (defcustom comint-password-prompt-regexp (concat - "\\(^ *\\|" + "\\(^ *\\|=0D" (regexp-opt '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" "Enter Auth" "enter auth" "Old" "old" "New" "new" "'s" "login" --=-=-=--