From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24727: 25.1; Editing custom theme removes undefined variables and faces Date: Fri, 04 Sep 2020 15:38:47 +0200 Message-ID: <87lfhpacgo.fsf@gnus.org> References: <87oa2if52f.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Allen Li , 24727@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 15:40:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBwy-0009QM-SW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 15:40:20 +0200 Original-Received: from localhost ([::1]:43984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEBwx-0004oN-Th for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 09:40:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEBvi-00024S-Ob for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEBvi-0005Mh-Dt for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEBvi-0005p0-3N for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24727 X-GNU-PR-Package: emacs Original-Received: via spool by 24727-submit@debbugs.gnu.org id=B24727.159922673822366 (code B ref 24727); Fri, 04 Sep 2020 13:39:02 +0000 Original-Received: (at 24727) by debbugs.gnu.org; 4 Sep 2020 13:38:58 +0000 Original-Received: from localhost ([127.0.0.1]:38032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBve-0005of-Jo for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:38:58 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBvd-0005oS-VD for 24727@debbugs.gnu.org; Fri, 04 Sep 2020 09:38:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K8Bq8kJVdY8GL2qqt/W1uNnABs8e8STPDLVghy3KVo4=; b=XODciAI4Is1Lo53pxjcezrsz0U vAxzR97IXSEV4/JVbqmNeBa0styGvjNarqkoW4nUWmAIWEJc3pzTgSITGjRS7fvYK1zFsYcCQtaUu T2rWEQUIEyki1P/1nt6cqPuruGcVpSEhBG5GG0Ex93vsh3LE1A9RFQU+gbAjFsl4EK30=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBvU-0000Ao-P6; Fri, 04 Sep 2020 15:38:51 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEX622P96mju2WDn pWOzoEjsbjbWhz70tYvv0qH55878+fH///+IxYaOAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+QJBA0k CUOfzEMAAAGASURBVDjLnZPBaoNAEIa1TxDbF4hroKG3uBU317JvIKm9lzbnIqlJTiki7u6pIDRZ T4Uc4u5T1piGyGgC7bAwsB///DMDYxiGaXWFcQFY/wUIuahvN8DRglYx6AT3ZwDaS7qAVX0iswvA rsxzA55X1NnBLq6e49oAeC/h5DWYeMEIgGGCg3kcx9EJHFaS8AxjXxP9ARQZKUqfkTh7A0BgUaQi IiFUiETwXbFjEnosUvYpPV/ItgLLXRBwfgJGb5/v2LhMJ+Gy0dVBQyKSE5wRDj1u13kUZ5L4DVCb OFk+87NZhOFKkjxM3tNgvIYg2j5FX3k8LVZw7duQ44ThZrt15t9THW/ERsJSYktEwrQan5Z4GJDl RHhMysUIgnXAH9nmedYqpXRZ6HKpV8BcSK201lI1PGqJ4IpoWbICblcoxQpZiVYQCCV1URWDAw4Z m7N92MCjFRfA7/+1i2yEUBtcUYrogLZBdWl2dWttcEPpA3Wa4HjnZq/f6zJvd2X9EfwAN7GyEqS2 dKkAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMDRUMTM6MzY6MDkrMDA6MDAnT2mFAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTA5LTA0VDEzOjM2OjA5KzAwOjAwVhLROQAAAABJRU5ErkJggg== X-Now-Playing: The Pentangle's _Cruel Sister_: "Jack Orion" In-Reply-To: (Mauro Aranda's message of "Fri, 4 Sep 2020 10:02:43 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187136 Archived-At: Mauro Aranda writes: > There is a check in custom-theme-write-variables for a bound symbol, and > a check in custom-theme-write-faces for a known face, and I wonder why, > because that should not be a concern for these functions. Yes, that seems odd. I had a short look around at the commit history here, but I was unable to find an explanation (but I didn't do an extensive examination). > But at least removing the checks makes it less rude, and undefined > variables or faces stay in the file. > > Here's my proposed patch. It makes sense to me (and the old behaviour didn't), so I've applied it to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no