From: Lars Ingebrigtsen <larsi@gnus.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: Allen Li <vianchielfaura@gmail.com>, 24727@debbugs.gnu.org
Subject: bug#24727: 25.1; Editing custom theme removes undefined variables and faces
Date: Fri, 04 Sep 2020 15:38:47 +0200 [thread overview]
Message-ID: <87lfhpacgo.fsf@gnus.org> (raw)
In-Reply-To: <CABczVweeAr3x1thLdVw-_=p7BZQwQ2Jj6GFoJ3LPDQqCsYBS-A@mail.gmail.com> (Mauro Aranda's message of "Fri, 4 Sep 2020 10:02:43 -0300")
Mauro Aranda <maurooaranda@gmail.com> writes:
> There is a check in custom-theme-write-variables for a bound symbol, and
> a check in custom-theme-write-faces for a known face, and I wonder why,
> because that should not be a concern for these functions.
Yes, that seems odd. I had a short look around at the commit history
here, but I was unable to find an explanation (but I didn't do an
extensive examination).
> But at least removing the checks makes it less rude, and undefined
> variables or faces stay in the file.
>
> Here's my proposed patch.
It makes sense to me (and the old behaviour didn't), so I've applied it
to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-09-04 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:13 bug#24727: 25.1; Editing custom theme removes undefined variables and faces Allen Li
2020-09-04 13:02 ` Mauro Aranda
2020-09-04 13:38 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfhpacgo.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24727@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.