From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#44100: Patch Date: Mon, 02 Nov 2020 21:38:21 -0500 Organization: GNU Message-ID: <87lffjf9lu.fsf__31064.4967177481$1604371184$gmane$org@gnu.org> References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> <87imaquq6z.fsf@gnu.org> <875z6pu8h5.fsf@gnu.org> <87mu01cjfh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20334"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 03 03:39:40 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZmEV-0005CM-UL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 03:39:39 +0100 Original-Received: from localhost ([::1]:34248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZmEU-0007oi-W1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 21:39:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZmDu-0007ld-Fm for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 21:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZmDu-00073t-65 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 21:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZmDu-0006pD-2z for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 21:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44100 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44100-submit@debbugs.gnu.org id=B44100.160437111126197 (code B ref 44100); Tue, 03 Nov 2020 02:39:02 +0000 Original-Received: (at 44100) by debbugs.gnu.org; 3 Nov 2020 02:38:31 +0000 Original-Received: from localhost ([127.0.0.1]:43048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZmDO-0006oT-Od for submit@debbugs.gnu.org; Mon, 02 Nov 2020 21:38:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZmDN-0006oH-GU for 44100@debbugs.gnu.org; Mon, 02 Nov 2020 21:38:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34968) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZmDH-00071n-Cz; Mon, 02 Nov 2020 21:38:23 -0500 Original-Received: from [2607:fea8:3fdf:f688:6557:fc41:50c6:42] (port=45128 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZmDH-0000Rk-4U; Mon, 02 Nov 2020 21:38:23 -0500 In-Reply-To: <87mu01cjfh.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192582 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: [...] > > Normalising to having a list of faces here sounds like a good idea, if > I'm skimming the code correctly, but it would probably help > comprehension a bit here if you renamed the parameter from `erc-face' to > something like `face-list'. Thanks. However, after staring at C-h f erc-track-find-face RET for a good while and experimenting in Edebug a fair bit, I have noticed that my change to C-h f erc-track-modified-channels RET for normalizing to always have a list breaks erc-track-find-face's algorithm in a non-trivial way, due its dependence on the structure of the two C-h v erc-track-faces-priority-list RET and C-h v erc-track-faces-normal-list RET lists. Since for the time being I don't have the time or energy to rethink those two functions' algorithms to work with a normalized list of lists for those two variables, I have decided to keep things as they are, and do the less evasive change in erc-ibuffer as suggested by Olivier to fix erc-ibuffer. I will commit that change over the few days, and will also try to clarify the docstring for C-h v erc-modified-channels-alist RET some more to more accurately describe its structure. I welcome anyone who would like to volunteer to send a patch for updating those functions to work with a normalized list of lists for those two variables, granted they can provide a convincing argument that their change is correct and does not break the current behaviour, does not dramatically further increase the complexity of the algorithms, and is ideally backward compatible with the current non-normalized structure of those two variables as well. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl+gwp0QHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8mO2D/9HzX0K9Xx3iBY0WcrbTtSpzs8TjRDfzSrO QipBEAhNVtCkNM7OxuyCHHYtXBnHPXOerXW2RtAyrsHsmLWXYh3I1M7ksbD4wSC6 Ng5dS9zAC7ddtU8a6QjMXsQ1UBC+1EeqOd1ysPpY4lOR+TdZppFaeutYb2CX4JaA tXJRQItDMdKtEoq2mNZ+meM43rvXjf3JiqgpP6cxbsmuwJsZym45kQ5iWq5pF+v/ IorxvuVTvXUPNw3GyZNSRzzLJRayu/QZhXJ3SGKUadNlW4ldzXLTiZ7oi8W1rLRm sacspokIUENzCq1Yj1u36nJBS0aTjq94YgvPid91vk9pSRSxeUOPhhuOY5eU6wSq KJ2O1igXCXA9VsXLISqjdL2QQW9n9+1yDdyjn/x8hqQn15b3AMeFoNtMpIcqewyf 3N/MgMtOiXPuqMeeixC3JMrm/CEw4YlgU/OhiMMIcyxCmWwm4vYMz76ENAuoe/sH Ke06hDC3s5LR4f9v+VsdxuG6drhEy4btpb2FfdEmdevv6sKGAhIbZtj4CEq6V2Cw uBACYIUt4OsEyfR3gCqO5ECIfQt5vHbnJxUyfedyf2q8yJoGsWoqZBkJRl7bMlCD Sh6tluZic0B5FxfFapUOEjGVOvfN0HGZ1RNxs6/wc6Zl6T1pVQ2Z7036cVqK9BnT OuS3b1o2kA== =F3ns -----END PGP SIGNATURE----- --=-=-=--