From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Wed, 04 Nov 2020 23:18:38 +0000 Message-ID: <87lffgpv75.fsf@tcd.ie> References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30596"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 00:19:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaS3t-0007sG-Hq for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 00:19:29 +0100 Original-Received: from localhost ([::1]:57232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaS3s-00070c-In for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 18:19:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaS3C-0006T5-OU for emacs-devel@gnu.org; Wed, 04 Nov 2020 18:18:46 -0500 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:35219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaS38-0002kd-Mx for emacs-devel@gnu.org; Wed, 04 Nov 2020 18:18:46 -0500 Original-Received: by mail-wr1-x436.google.com with SMTP id n15so290853wrq.2 for ; Wed, 04 Nov 2020 15:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4MeoFn53u6L/lqQ1P78/GHqdWYrgMUHpdIRwCwGZND0=; b=V3jEYAFnCqdHkBp8r2/GBswKyuDnsAdY0gsnq5cZ/0hjZ6CI8PgEsa6HzvoOUmAitj RU3i4M/Q5Y0gm6+CMbqIoQ4FjfSAD1x1mpOPKRRLEZdYo0QFnXdif29c00j4/3YvgjyO V2XpINzzQhfD+k/GOUmfPekfCa0l7THjOrLPMqnP8+/9TKXMLc2OMh3LmGhp50Lo+VU0 XnIgcwkPtspUP5ZS+KTm1QBJg3wBAwDdJtqbtdq5OL6RjzkeciQ3wIREBewJuihlyDih 7ObDRiJim1RllHWMCex7PDH49eP5OVLwYeGOc4D6RMwgwjBJ98bKuxqXPI8iZBzc98zd BIZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4MeoFn53u6L/lqQ1P78/GHqdWYrgMUHpdIRwCwGZND0=; b=JLTf4nJuMlomOHtlxt34v/1lPgamkRu6fyJFepFLXvBPGwyR4TKq2jQEoR23EV8M27 g0XJQLdNtUPdMoRPc4s4TsK0O6qh+zSCH7xg0lgc2JujgkTScIk8gb0d1c6VBvofdOGq MN/rNpVeiwSDtHRhFVaEVl2TXduPhH2bGWyDeQ0lmVAfwflIkw2NgFnGwlLakURYCL7W Ph5VcQBms89D+f73WPVtqliWXplGAQNOmLvHdfypr7eftKGXtt6/bo2msKpMQO/tbCbQ 3nmHAJ4DQjD91B+M1lcaxHIoLKmmmvF+3UpLrGPHjCYflm4zJMvEylgC2KskHkM1QunT 7Izg== X-Gm-Message-State: AOAM530vCDPbAXQ5itppLmXiGAL3O8rcOj40wSaHgCB25Ys28oMSBGot WaTKSNGIvwJWRU31W+LEaDdLtQ== X-Google-Smtp-Source: ABdhPJznwTrC7qKGJtCkFb4xZbjtby+Z1jml/nJ4K5lne/fgpAZ7DrZcZL8QNsLQZJWT/QpgGNEiPw== X-Received: by 2002:adf:dd46:: with SMTP id u6mr333100wrm.295.1604531920471; Wed, 04 Nov 2020 15:18:40 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id y20sm4181224wma.15.2020.11.04.15.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 15:18:39 -0800 (PST) In-Reply-To: <20201104161200.tyeo2r5jibdahukb@Ergus> (Ergus's message of "Wed, 4 Nov 2020 17:12:00 +0100") Received-SPF: none client-ip=2a00:1450:4864:20::436; envelope-from=contovob@tcd.ie; helo=mail-wr1-x436.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258705 Archived-At: Ergus writes: > The icomplete-vertical feature branch is pretty much ready, please if > any maintainer could give it a last review and tell me anything else > needed to merge into master? Thanks. I've never used icomplete before, but FWIW I just gave it a quick whirl with icomplete-separator set to "\n" and the orderless package installed, and it seems to work fine. The only thing that caught my eye in the code is that variables defined with defvar-local can be set with setq; they don't need setq-local, since they automatically become buffer-local when set. > OTOH the highlight-completions branch is almost ready too. I have more > doubts about this and maybe I will be doing some unneeded things there, > so maybe a review with some critics and advises will be very very > welcome. I have yet to try this branch out, but it sounds cool. -- Basil