From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: emacs | Pipeline #8399 has failed for master | ee0e259e Date: Wed, 06 Jan 2021 13:15:23 +0100 Message-ID: <87lfd6cld0.fsf@gmx.de> References: <5feaf98365b55_3f903d428113941@emba.gnu.org.mail> <87o8ica9xp.fsf@gmx.de> <87pn2s35a2.fsf@gmail.com> <87ft3oa4pz.fsf@gmx.de> <8735zo9ui7.fsf@gmx.de> <87h7nw39gg.fsf@gmail.com> <87im8b3jo6.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 06 13:17:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kx7l6-000AU0-Cp for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 13:17:48 +0100 Original-Received: from localhost ([::1]:37170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kx7l5-0005kX-9I for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 07:17:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kx7iw-0004Dk-IV for emacs-devel@gnu.org; Wed, 06 Jan 2021 07:15:34 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:55355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kx7iu-0006Vx-HB for emacs-devel@gnu.org; Wed, 06 Jan 2021 07:15:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609935325; bh=QhWJBUpYIks2B+ap88ur8GwZrMmh2zhNDTZaCRmGpHQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=X2ptNHX0NrxRrGjzb0pbuX0c2QSxOE6IDDNmlBv5+1ezzbGzCeI7rXG0IfeeLeTfM 2zGBRC/TWfa0jhm/VpewMooSo005YT2Q0H4GOaX1m3ymcxY785IpuRrip3Vi/zFJtd 90YPFa+IjhQgGlQpE4HyVayGvK58eaZCeAwt2NeA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.249.16]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MIwzA-1kiKvO3nyM-00KQlf; Wed, 06 Jan 2021 13:15:25 +0100 In-Reply-To: (Philipp Stephani's message of "Tue, 5 Jan 2021 14:44:56 +0100") X-Provags-ID: V03:K1:SINjsPLjfQA+UtUQAME9bI6zxgXWE8UKR9tI3WcwNR/AYMYH9lF 2seu4lHN8OdmIZ+CQQ9ZVw3F3h61oM+IGCjjFkRFRnx9qGRFE0NBawVVrj4fsYS8ATNSpRq Dw5+ZgLBmDkuUmUkwrgRyy90e9d5Td3cVrKIfzTRvnvGTqwAQoWKrqqxOJEcoc20HkpF0YT lpgL71iN6spZ6HHtYIvjA== X-UI-Out-Filterresults: notjunk:1;V03:K0:3d2oIffpd9s=:NOvIa8kH08zDCkllORovQ+ GUtj98czFXSxbxYgD7stFD9YpdS8DMH3+hrcy39h44czEpFEjBpRK2OO6Dtwrufwi+wp9sJNI GCUsq4IRK1R9AN5P5mHfr5vru5X1ljO7NfUCb9wj+/b0yK1DRbDDyn5jKONoUioqoTfjUk4dr losqnb3/BSAn03r1IA1hwdscMCNTPW4dqCdIusofOZ7Y47tWGKnsnBF8BFzxbQIe/DFbhPOw/ wt+t+wCKwjvbGzM1ZFk6SAbvgBMDh8m/Zd+t+VgA9PQbJLXVkbCjmgG3TxOt9q0fSpbvmpWeD EFIfy7osqJUXfYK6VN3JF98yljHrsJ/xOtS9KMh+hNtKdekK2gxrWZp49qXAzFpI+eFq4r58F azYE8yY32GK5WdPXH7weVVszYzF4+h2TsgfBxaDDGJl+/Su2oSRy86SJIowY7qhAlFHDolxnw rn8v4mqu6GC7A1YhizkAZcyC+Uj/gFMQJrGKVbXAuPoZjIabbvaBFO12dc09kAd7ndbKAo2QG Li2ywC4+SkVSO9Ao+tqhZ9V41c4HJ+xoQWVX+f8ac+u3WrsL4grCDhZBHU+++lCcsjKB6K3fO 8kwkqagiafEu18jiY3ERAxoYppHwzHYehgPmX822xe5FRw0BKiU5umkZ0XQR8t/gesVvqwuGl lnP63Ug3/bgQGRM1Z9GZn4JxR1yp6Xcxzr32pSG6kkYu6VsOz+t+3TkA1/c6z/WRc1ypZRSr9 q1+QEmnpbRheAnf9WXrPSwZJCVXLRN9qawgncbqve1Yd0kI/smmbzBo4S7l3RFfFkLMG+O8v Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262590 Archived-At: Philipp Stephani writes: Hi Philipp, >> >> process-test-sentinel-wait-function-working-p which is used by >> >> process-test-sentinel-sit-for looks racy. Just because the process >> >> sentinel has been called is no guarantee that the process has exited >> >> and had its process-status set correctly, perhaps it should loop on >> >> 'process-live-p' >> > >> > AFAIK the only correct way to wait for a process to exit is (while >> > (accept-process-output PROC)). >> >> I vaguely remember that Stefan did propose (while (accept-process-output >> PROC 0)). > > I guess that would work as well, but wouldn't it result in a busy > wait? No. If there's no output, or the connection is closed, it shall return nil. Well, this is also true for (while (accept-process-output PROC)), but this could block if the process just waits for something to happen. Sure, the process shall exit in the given test situation. But we test *whether* it happens, and shall be prepared that it fails. (OTOH we have wrapped now the tests with a 60 second timeout; this might be sufficient.) Best regards, Michael.