From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: Patch to avoid flicker in Isearch with lazy count Date: Thu, 28 Jan 2021 12:17:06 +0100 Message-ID: <87lfcd5n0t.fsf@gmail.com> References: <87r1m6jsk7.fsf@gmail.com> <87lfce2ruh.fsf@mail.linkov.net> <87tur1bjof.fsf@gmail.com> <871re5e809.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26755"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 28 12:17:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l55JA-0006rO-Vb for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 12:17:52 +0100 Original-Received: from localhost ([::1]:50176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l55JA-0004jr-2N for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 06:17:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l55IV-0004JR-3Q for emacs-devel@gnu.org; Thu, 28 Jan 2021 06:17:11 -0500 Original-Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:40252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l55IT-0005yj-Lc for emacs-devel@gnu.org; Thu, 28 Jan 2021 06:17:10 -0500 Original-Received: by mail-ej1-x62a.google.com with SMTP id gx5so7147920ejb.7 for ; Thu, 28 Jan 2021 03:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=W9gnaxMc+XuEHcEGd1w/r5IeAHYK9OaXU+7IeMaCG9s=; b=fMJ3ZIj9MRexLX9SmGAwiRZOAyrjZFQIhLoB9NKAQNCxJUEwwMyOnnGmA8d9NuZ8mK ptc5O6qHUvx1zRIY9VLqv+x2/Y86ViRPnAxWCKGZsrvMR9hzDSVnYPtHBsru6ZuaVi8B 8Vm9LPOdy19eFeF96OQAObsB37GLGU1aKiXG3vZIItOr1+CzUTrd/dmgnY8TD5rNwMhx 7bWzOXGadCQy8+Lqq5eK09cqaNii4mpG2F9DZGmV/8kV5aPxpUu8mzsbt3n89khlq6ac er6TrFJ2NX1uyZcXtzBkQ4EDekVTzgWTcxgXYm6AnoqiKbehrQI4mgd6IZRrjXtyrfrl DEYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=W9gnaxMc+XuEHcEGd1w/r5IeAHYK9OaXU+7IeMaCG9s=; b=U5wGvgDQWCGpTstrBrjYurq1pTUoytVD7EBG8MQ4BKMFTykHp8rc8LouZIvG/1lNi+ 4W/0JLn7Wjck2JXNLM3i9yFyyECyJ0Kn4/QXU37+hfeDTNYfeJNCLMdYsQyLuES08rZg Gr47g6IALqV7gJE6YSlfRiV3VP4N/y0+wq8j5Ofe1ESLOKI+tpw3iST0jDo9TgTydObv N4uoNgZZArS+z5BxPbeAUZOQDaa58izc7jTeYzfZfKsIE5C6G3+PpuxVxHWZMTA6oYCC ooE+hcfItO+s6JfwvNH8s8RUUNmcCqsczI5TmtCnIdJOGKGuIpU5GUor1QRg+7VJJrQ4 VLJw== X-Gm-Message-State: AOAM533TUxbrRZX2WfxlKcOJkW++FMQC+R1hjeZq8b4r61A+t+nvK6Zo +Bhy6bRuJ6URFOXmQZ2UT7joRRcm0Pg= X-Google-Smtp-Source: ABdhPJxdthcLl/8OC3nZ0kLtjK9J2agojTGQZcH00m5Jsa1Jxq3Z9cxzWOHvEPBF/Gg4OJuSwEzFKQ== X-Received: by 2002:a17:906:7f83:: with SMTP id f3mr10166690ejr.282.1611832627967; Thu, 28 Jan 2021 03:17:07 -0800 (PST) Original-Received: from ars3 ([2a02:908:2211:8540::16e5]) by smtp.gmail.com with ESMTPSA id dm6sm2051279ejc.32.2021.01.28.03.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 03:17:07 -0800 (PST) In-Reply-To: <871re5e809.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 28 Jan 2021 11:06:38 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263545 Archived-At: On Thu, 28 Jan 2021 at 11:06, Juri Linkov wrote: > Definitely, =E2=80=98lazy-highlight-delay-max-chars=E2=80=99 should not a= ffect > =E2=80=98lazy-highlight-interval=E2=80=99 because with pauses between hig= hlighting > portions of matches, when lazy-highlight-buffer-max-at-a-time is 20, > this could create a situation when only first 20 matches are counted, > and during the delay before processing the next portion of matches, > the users might think this is the final total of all existing matches, > so this is misleading for users. Good, I'll make it so. By the way, why is the default =E2=80=98lazy-highlight-buffer-max-at-a-time=E2=80=99 (20) so low? The ove= rhead of creating a timer for every 20 matches is pretty substantial. On my machine, a value like 500 or 1000 makes the lazy count finish visibly faster, and doesn't affect responsiveness even in huge files.