From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50042: 26.3; Post-command hooks slow with M-x commands Date: Fri, 13 Aug 2021 14:27:42 +0200 Message-ID: <87lf55edhd.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7644"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50042@debbugs.gnu.org To: Simon Katz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 13 14:28:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEWID-0001mG-IB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 14:28:09 +0200 Original-Received: from localhost ([::1]:45846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEWIC-0002UM-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 08:28:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEWI6-0002RV-Bl for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 08:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEWI6-0000Ay-3f for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 08:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEWI5-0008CH-WF for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 08:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Aug 2021 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50042 X-GNU-PR-Package: emacs Original-Received: via spool by 50042-submit@debbugs.gnu.org id=B50042.162885767831498 (code B ref 50042); Fri, 13 Aug 2021 12:28:01 +0000 Original-Received: (at 50042) by debbugs.gnu.org; 13 Aug 2021 12:27:58 +0000 Original-Received: from localhost ([127.0.0.1]:40712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEWI2-0008By-4s for submit@debbugs.gnu.org; Fri, 13 Aug 2021 08:27:58 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEWHy-0008Bh-C7 for 50042@debbugs.gnu.org; Fri, 13 Aug 2021 08:27:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aoJHdi++Xgybmtb575P/LXnLnC06Dg29H4E0D+YyLJY=; b=UUBnqAyfptVlGmrtrZm34VBwBh mKogMyIPcAy35DgSY/N3d8w4N0+XqhQQTxU8RPkf8wPfb14VqLPPP2CF1FjVFHfIOAzAZ+4rVNv4R E5fB9Se/aKGKNdSkTnrgF3N/1KSc2LHXESNYcUyOxDelzzHpuBjFGuKNv4wdwAQyt/Vk=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEWHn-0003XW-5e; Fri, 13 Aug 2021 14:27:47 +0200 In-Reply-To: (Simon Katz's message of "Fri, 13 Aug 2021 12:52:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211744 Archived-At: Simon Katz writes: > Here's a startup file that can be used to show this (also at Simpler repro: (add-hook 'post-command-hook (lambda () (let ((inhibit-message t)) (message "foo: %s" this-command)))) (display-buffer "*Messages*") M-x previous-line I think this has something to do with the You can run the command =E2=80=98previous-line=E2=80=99 with C-p stuff -- if the `M-x' command in question isn't bound to anything, `post-command-hook' is run immediately instead of after a two-second timeout. Hm... yup: `execute-extended-command' ends with (when binding (with-temp-message (format-message "You can run the command `%s' with %s" function (if (stringp binding) (concat "M-x " binding " RET") (key-description binding))) (sit-for (if (numberp suggest-key-bindings) suggest-key-bindings 2)))))))) So presumably `post-command-hook' isn't run after that timeout has completed. Uhm... anybody got any ideas how to fix this? I mean, in one way it's behaving as it's supposed to -- the command really isn't finished after this sit-for has finished. On the other hand, it's pretty awkward. Could we yank this out of the flow and run it from a timer (fired immediately) instead? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no