From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40335: 27.0.90; elp-not-profilable not up to date Date: Sat, 18 Sep 2021 18:44:06 +0200 Message-ID: <87lf3trfzd.fsf@gnus.org> References: <87wo6ja15q.fsf@gmail.com> <85sgh7zar6.fsf@gmail.com> <87sgh79zbm.fsf@gmail.com> <85pncbz80d.fsf@gmail.com> <87o8rv9vgy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40335@debbugs.gnu.org, Philipp Stephani , Noam Postavsky To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 18:45:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRdSf-0008Vz-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 18:45:09 +0200 Original-Received: from localhost ([::1]:54806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRdSe-0005eu-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 12:45:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRdSX-0005eZ-Tz for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 12:45:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRdSX-0005V5-Mc for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 12:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRdSX-0005CL-IK for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 12:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40335 X-GNU-PR-Package: emacs Original-Received: via spool by 40335-submit@debbugs.gnu.org id=B40335.163198346219907 (code B ref 40335); Sat, 18 Sep 2021 16:45:01 +0000 Original-Received: (at 40335) by debbugs.gnu.org; 18 Sep 2021 16:44:22 +0000 Original-Received: from localhost ([127.0.0.1]:36669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdRt-0005B1-MO for submit@debbugs.gnu.org; Sat, 18 Sep 2021 12:44:21 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdRp-0005Ak-GM for 40335@debbugs.gnu.org; Sat, 18 Sep 2021 12:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RNmxGYfUeyk+SgExN5nap7o3+n76N9k6BJ73YvmTFq0=; b=XoclJAMGGLyEBthUBLR0fYJu0K 5L9gsNWPgbNQDY4y3bNjMUSy7C2US6JJfbRnKajgQcbZh1BLxqR3o2tOh4kQTk/Kd1dFvCsvH7N/i oNMvSuLQjpwNyKSGkCGy6EQxPitlqB1YIDy5L7s+DY8/p+X+mcJ2UP6T5n/73zJWuKuo=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRdRg-0005OZ-8Q; Sat, 18 Sep 2021 18:44:10 +0200 In-Reply-To: <87o8rv9vgy.fsf@gmail.com> ("=?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?="'s message of "Mon, 13 Apr 2020 18:55:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214645 Archived-At: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: > I wonder what the best way forward is here. (info "(elisp) Profiling") > states that elp "is limited to profiling functions written in Lisp, it > cannot profile Emacs primitives". So given that of the problem-makers > only `error' is a Lisp function, the simplest solution would be just > replacing `special-form-p' with `subrp' in `elp-profilable-p', thus > disallowing instrumenting primitives altogether. I think it means that it can't profile the innards of C functions -- but doing `M-x elp-profile-function RET - RET' works fine, as far as I can tell? (dotimes (i 1000) (- 1 2)) `M-x elp-results RET': - 1000 0.000410623 4.10623e-07 > If we want to preserve the partial support for primitives, do we want to > support as much as possible, e.g. by runtime-checking if > `elp--make-wrapper' is compiled and determine the set of problem-makers > dynamically, or do we just update the static `elp-not-profilable' list > conservatively (i.e., including _all_ functions called from the > wrappers, to make sure they don't cause problems even when > `elp--make-wrapper' is run interpreted)? I think we should just update `elp-not-profilable', but we should assume that `elp--make-wrapper' is byte-compiled. (Otherwise it'd be less useful.) Anybody have any other opinions here? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no