all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Carlos Pita <carlosjosepita2@gmail.com>
Cc: 51309@debbugs.gnu.org
Subject: bug#51309: 28.0.60; [Feature Request] Allow to customize tab-bar button images
Date: Thu, 21 Oct 2021 19:46:13 +0300	[thread overview]
Message-ID: <87lf2mzaca.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAEOO5TeyQf8LB6TU3QjuAgKAwFDRu1SOGS4ZQqGOHygfY1VbcA@mail.gmail.com> (Carlos Pita's message of "Wed, 20 Oct 2021 19:03:01 -0300")

> as you can see in the attached images, the xpm files provided for
> tab-bar buttons don't look very well in many cases:
>
> 1. They are low resolution so they are scaled x 2 in HiDPI screens
> (when there is support for this, I guess for other users they look
> tiny instead).
> 2. The light background is particularly ugly (at least IMO) with dark
> themes and, in general, I believe the ability to blend the button
> background with the default background would be appreciated by a
> number of users.
> 3. Vertical alignment looks slightly off center.

They look sufficiently well but there is always room for improvement.
All suggestions are welcome.

> Maybe "tabs/close.xpm" is already intended to be an abstract
> specification of an xpm that is then loaded as described in [1]:
>
>> If file is not an absolute file name, it is expanded relative to the
>> images subdirectory of data-directory
>
> so that each theme has to locally, temporally(, whatever) override
> data-directory somehow, but I believe it's not like that, I believe
> icons are simply hardcoded.
>
> Given the shortcomings listed above, why not provide some customizable
> variables to change the icons?

This definitely should be customizable, but it's unclear what do you
want to customize: only the file path to the image, or allow to set
the button propertized with an image with image properties like
:margin/:ascent?

Could you send such a button string with an image that looks good
on HiDPI screens?  Then we could try to make a customizable option
based on your design.





  reply	other threads:[~2021-10-21 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 22:03 bug#51309: 28.0.60; [Feature Request] Allow to customize tab-bar button images Carlos Pita
2021-10-21 16:46 ` Juri Linkov [this message]
2021-10-21 20:30 ` Carlos Pita
2021-10-22  7:01   ` Juri Linkov
2022-10-24  7:34 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf2mzaca.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=51309@debbugs.gnu.org \
    --cc=carlosjosepita2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.