From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 51712@debbugs.gnu.org
Subject: bug#51712: 29.0.50; [PATCH] New function `xwidget-webkit-load-html'
Date: Thu, 11 Nov 2021 08:31:34 +0800 [thread overview]
Message-ID: <87lf1v353t.fsf@yahoo.com> (raw)
In-Reply-To: <83r1bo2ilp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Nov 2021 16:25:22 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: larsi@gnus.org, 51712@debbugs.gnu.org
>> Date: Wed, 10 Nov 2021 21:03:26 +0800
>>
>> Thank you! How does the attached patch look to you?
>
> LGTM, thanks. But please fix this gotcha when you push:
>
>> +@defun xwidget-webkit-load-html xwidget text &optional base-uri
>> +Load @var{text}, a string, into @var{xwidget}, which should be a
>> +WebKit xwidget. Any HTML markup in @var{text} will be processed
>> +by @var{xwidget} while rendering the text.
>> +
>> +Optional argument @var{base-uri}, which should be a string, specifies
>> +the absolute location of the web resources referenced by @var{text},
>> +to be used for resolving relative links in @var{text}.
>> +
>
> This lacks "@end defun" at the end.
Thanks, fixed and pushed.
next prev parent reply other threads:[~2021-11-11 0:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <878rxx8w1i.fsf.ref@yahoo.com>
2021-11-09 10:26 ` bug#51712: 29.0.50; [PATCH] New function `xwidget-webkit-load-html' Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 13:21 ` Eli Zaretskii
2021-11-09 13:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 14:07 ` Eli Zaretskii
2021-11-09 23:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 0:02 ` Lars Ingebrigtsen
2021-11-10 0:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 0:22 ` Lars Ingebrigtsen
2021-11-10 2:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 5:59 ` Lars Ingebrigtsen
2021-11-10 6:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 12:50 ` Eli Zaretskii
2021-11-10 13:03 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 14:25 ` Eli Zaretskii
2021-11-11 0:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-11-10 4:34 ` Richard Stallman
2021-11-10 4:37 ` Lars Ingebrigtsen
2021-11-11 3:37 ` Richard Stallman
2021-11-10 4:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-09 18:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf1v353t.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=51712@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.