[BUG] Citations: Locator treated as prefix [9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)]

[BUG] Citations: Locator treated as prefix [9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)]

[M. ‘quintus’ Gülker]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Dear all,

I originally reported this at
https://github.com/andras-simonyi/citeproc-el/issues/68, but was
directed here.

take this org file `mwe.org':

    #+TITLE: Test
    #+AUTHOR: Testauthor
    #+LANGUAGE: de
    #+bibliography: /tmp/mwe/mwe.bib
    #+cite_export: csl /tmp/mwe/juristische-schulung.csl

    Das ist ein Test [cite:@redeker2020itr Kap. A Rn. 72, Suffixtext hier]

with this `mwe.bib' Biblatex file:

    @Book{redeker2020itr,
    author       = {Helmut Redeker},
    title        = {IT-Recht},
    year      = {2020},
    edition   = {7},
    publisher = {C.H. Beck},
    location  = {München},
    langid    = {ngerman}}

`juristische-schulung.el' is https://github.com/citation-style-language/styles/blob/e22b8a566bad9b4c7f52720f60dd875057a5d210/juristische-schulung.csl

When this is exported to HTML, the locator `Kap. A Rn. 72' is split and
partly taken as the prefix. It exports to this:

    1 Kap. A Rn.  Redeker, IT-Recht, 7. Aufl. (2020), 72 Suffixtext hier

This is incorrect; it should export to:

    1 Redeker, IT-Recht, 7. Aufl. (2020), Kap. A Rn. 72 Suffixtext hier

Org mode version 9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)
citeproc.el at e6b3f160dbe87d035cbee6c61bcfdd063f56b1cb

  -quintus

Emacs  : GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-03-28, modified by Debian
Package: Org mode version 9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-persist-before-write-hook '(org-element--cache-persist-before-write)
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-mode-hook '((closure
		  (org-agenda-skip-regexp org-table1-hline-regexp org-table-tab-recognizes-table\.el
		   org-table-dataline-regexp org-table-any-border-regexp
		   org-agenda-restriction-lock-overlay org-agenda-overriding-restriction
		   org-agenda-diary-file org-complex-heading-regexp t)
		  nil (setq imenu-create-index-function 'org-imenu-get-tree))
		 (closure
		  (org--rds reftex-docstruct-symbol org-element-greater-elements
		   visual-fill-column-width org-clock-history org-agenda-current-date org-with-time
		   org-defdecode org-def org-read-date-inactive org-ans2 org-ans1
		   org-columns-current-fmt-compiled org-clock-current-task org-clock-effort
		   org-agenda-skip-function org-agenda-skip-comment-trees org-agenda-archives-mode
		   org-end-time-was-given org-time-was-given org-log-note-extra org-log-note-purpose
		   org-log-post-message org-last-inserted-timestamp org-last-changed-timestamp
		   org-entry-property-inherited-from org-blocked-by-checkboxes org-state
		   org-agenda-headline-snapshot-before-repeat org-agenda-buffer-name
		   org-agenda-start-on-weekday org-agenda-buffer-tmp-name org-priority-regexp
		   org-mode-abbrev-table org-mode-syntax-table org-element-use-cache
		   org-element-cache-persistent buffer-face-mode-face org-tbl-menu org-org-menu
		   org-struct-menu org-entities org-last-state org-id-track-globally
		   org-clock-start-time texmathp-why remember-data-file
		   org-agenda-tags-todo-honor-ignore-options iswitchb-temp-buflist
		   calc-embedded-open-mode calc-embedded-open-formula calc-embedded-close-formula
		   align-mode-rules-list org-emphasis-alist org-emphasis-regexp-components
		   org-export-registered-backends org-modules crm-separator org-babel-load-languages
		   org-id-overriding-file-name org-indent-indentation-per-level
		   org-element-paragraph-separate org-agenda-buffer-name org-inlinetask-min-level t)
		  nil (add-hook 'change-major-mode-hook 'org-show-all 'append 'local))
		 (closure
		  (org-src-window-setup *this* org-babel-confirm-evaluate-answer-no
		   org-babel-tangle-uncomment-comments org-src-preserve-indentation
		   org-src-lang-modes org-edit-src-content-indentation org-babel-library-of-babel t)
		  nil (add-hook 'change-major-mode-hook #'org-babel-show-result-all 'append 'local))
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-odt-format-drawer-function '(closure
				  (hfy-user-sheet-assoc hfy-html-quote-regex hfy-html-quote-map
				   hfy-face-to-css hfy-begin-span-handler hfy-end-span-handler
				   archive-zip-extract nxml-auto-insert-xml-declaration-flag t)
				  (_name contents) contents)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-persist-before-read-hook '(org-element--cache-persist-before-read)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-persist-after-read-hook '(org-element--cache-persist-after-read)
 org-bibtex-headline-format-function '(closure
				       (org-id-locations org-agenda-search-view-always-boolean
					org-agenda-overriding-header t)
				       (entry) (cdr (assq :title entry)))
 org-latex-format-drawer-function '(closure (t) (_ contents) contents)
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-ascii-format-drawer-function '(closure (t) (_name contents _width) contents)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link)
		       ("id" :follow org-id-open)
		       ("eww" :follow org-eww-open :store org-eww-store-link)
		       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
		       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
		       ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export)
		       ("info" :follow org-info-open :export org-info-export :store
			org-info-store-link)
		       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
		       ("docview" :follow org-docview-open :export org-docview-export :store
			org-docview-store-link)
		       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
			org-bbdb-complete-link :store org-bbdb-store-link)
		       ("w3m" :store org-w3m-store-link)
		       ("doi" :follow org-link-doi-open :export org-link-doi-export)
		       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
		       ("elfeed" :follow elfeed-link-open :store elfeed-link-store-link) ("file+sys")
		       ("file+emacs") ("shell" :follow org-link--open-shell)
		       ("news" :follow
			(closure
			 ((scheme . "news") (--dolist-tail--) org-ts-regexp org-time-stamp-formats
			  org-src-source-file-name org-outline-regexp-bol org-inhibit-startup
			  org-id-link-to-org-use-id org-highlight-links org-comment-string
			  org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
			 (url arg) (browse-url (concat scheme ":" url) arg))
			)
		       ("mailto" :follow
			(closure
			 ((scheme . "mailto") (--dolist-tail--) org-ts-regexp org-time-stamp-formats
			  org-src-source-file-name org-outline-regexp-bol org-inhibit-startup
			  org-id-link-to-org-use-id org-highlight-links org-comment-string
			  org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
			 (url arg) (browse-url (concat scheme ":" url) arg))
			)
		       ("https" :follow
			(closure
			 ((scheme . "https") (--dolist-tail--) org-ts-regexp org-time-stamp-formats
			  org-src-source-file-name org-outline-regexp-bol org-inhibit-startup
			  org-id-link-to-org-use-id org-highlight-links org-comment-string
			  org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
			 (url arg) (browse-url (concat scheme ":" url) arg))
			)
		       ("http" :follow
			(closure
			 ((scheme . "http") (--dolist-tail--) org-ts-regexp org-time-stamp-formats
			  org-src-source-file-name org-outline-regexp-bol org-inhibit-startup
			  org-id-link-to-org-use-id org-highlight-links org-comment-string
			  org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
			 (url arg) (browse-url (concat scheme ":" url) arg))
			)
		       ("ftp" :follow
			(closure
			 ((scheme . "ftp") (--dolist-tail--) org-ts-regexp org-time-stamp-formats
			  org-src-source-file-name org-outline-regexp-bol org-inhibit-startup
			  org-id-link-to-org-use-id org-highlight-links org-comment-string
			  org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
			 (url arg) (browse-url (concat scheme ":" url) arg))
			)
		       ("help" :follow org-link--open-help :store org-link--store-help)
		       ("file" :complete org-link-complete-file)
		       ("elisp" :follow org-link--open-elisp))
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-link-elisp-confirm-function 'yes-or-no-p
 org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
 org-html-format-drawer-function '(closure
				   (htmlize-buffer-places org-html-format-table-no-css
				    htmlize-css-name-prefix htmlize-output-type htmlize-output-type
				    htmlize-css-name-prefix t)
				   (_name contents) contents)
 org-html-format-headline-function 'org-html-format-headline-default-function
 )

-- 
Dipl.-Jur. M. Gülker | https://mg.guelker.eu | PGP: Siehe Webseite
Passau, Deutschland  | kontakt@guelker.eu    | O<

Re: [BUG] Citations: Locator treated as prefix [9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)]

[Nicolas Goaziou]

Hello,

M. ‘quintus’ Gülker <post+orgmodeml@guelker.eu> writes:

> take this org file `mwe.org':
>
>     #+TITLE: Test
>     #+AUTHOR: Testauthor
>
>     #+LANGUAGE: de
>     #+bibliography: /tmp/mwe/mwe.bib
>
>     #+cite_export: csl /tmp/mwe/juristische-schulung.csl
>
>     Das ist ein Test [cite:@redeker2020itr Kap. A Rn. 72, Suffixtext hier]
>
> with this `mwe.bib' Biblatex file:
>
>     @Book{redeker2020itr,
>     author       = {Helmut Redeker},
>     title        = {IT-Recht},
>     year      = {2020},
>     edition   = {7},
>     publisher = {C.H. Beck},
>     location  = {München},
>     langid    = {ngerman}}
>
> `juristische-schulung.el' is https://github.com/citation-style-language/styles/blob/e22b8a566bad9b4c7f52720f60dd875057a5d210/juristische-schulung.csl
>
> When this is exported to HTML, the locator `Kap. A Rn. 72' is split and
> partly taken as the prefix. It exports to this:
>
>     1 Kap. A Rn.  Redeker, IT-Recht, 7. Aufl. (2020), 72 Suffixtext hier
>
> This is incorrect; it should export to:
>
>     1 Redeker, IT-Recht, 7. Aufl. (2020), Kap. A Rn. 72 Suffixtext
>     hier

This is because "Kap." is not known as a locator identifier. See
‘org-cite-csl--label-alist’ for the full list of such identifiers.

I don’t think it is reasonable to expect this variable to contain every
identifier in every language. It may be a good idea to turn the variable
above into a defcustom, thus.

Meanwhile, you can test again after evaluating:

  (push '("Kap." . "chapter") org-cite-csl--label-alist)

Regards,
-- 
Nicolas Goaziou

Re: [BUG] Citations: Locator treated as prefix [9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)]

[M. ‘quintus’ Gülker]

Am Freitag, dem 12. November 2021 schrieb Nicolas Goaziou:
> This is because "Kap." is not known as a locator identifier. See
> ‘org-cite-csl--label-alist’ for the full list of such identifiers.

You are right, sir. “Kap.” is German for “chapter” and CSL does have a
localisable chapter locator. Using

    Das ist ein Test [cite:@redeker2020itr chapter A Rn. 72, Suffixtext hier]

results indeed in the desired

    1 Redeker, IT-Recht, 7. Aufl. (2020), Kap. A Rn. 72 Suffixtext hier

. Thanks for pointing it out.

> I don’t think it is reasonable to expect this variable to contain every
> identifier in every language. It may be a good idea to turn the variable
> above into a defcustom, thus.

Probably, but I will leave this to you. Just using the standard
“chapter” selector resolves my problem here.

> Meanwhile, you can test again after evaluating:
>
>   (push '("Kap." . "chapter") org-cite-csl--label-alist)

Interestingly, doing this does not make it work for me, the “Kap.” still
is displays at the beginning.

  -quintus

-- 
Dipl.-Jur. M. Gülker | https://mg.guelker.eu | PGP: Siehe Webseite
Passau, Deutschland  | kontakt@guelker.eu    | O<

Re: [BUG] Citations: Locator treated as prefix [9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)]

[Nicolas Goaziou]

M. ‘quintus’ Gülker <post+orgmodeml@guelker.eu> writes:

>> I don’t think it is reasonable to expect this variable to contain every
>> identifier in every language. It may be a good idea to turn the variable
>> above into a defcustom, thus.
>
> Probably, but I will leave this to you. Just using the standard
> “chapter” selector resolves my problem here.

Good. I’m not sure but I think it would be more natural if locators
could be expressed in user’s language. I will let actual users chime in.

>> Meanwhile, you can test again after evaluating:
>>
>>   (push '("Kap." . "chapter") org-cite-csl--label-alist)
>
> Interestingly, doing this does not make it work for me, the “Kap.” still
> is displays at the beginning.

Indeed. I forgot to say you also need to re-evaluate
‘org-cite-csl--label-regexp’ definition (in "oc-csl.el"), in order to
refresh the locator regexp matched against.

Regards,

Re: [BUG] Citations: Locator treated as prefix [9.5 (release_9.5-225-g494c20 @ /home/quintus/.emacs.d/org-mode/lisp/)]

[M. ‘quintus’ Gülker]

Am Freitag, dem 12. November 2021 schrieb Nicolas Goaziou:
> Indeed. I forgot to say you also need to re-evaluate
> ‘org-cite-csl--label-regexp’ definition (in "oc-csl.el"), in order to
> refresh the locator regexp matched against.

Ah, I see. Indeed, re-evaluating that definition after amending
`org-cite-csl--label-alist' results in the desired result on export.

Thanks!

  -quintus

-- 
Dipl.-Jur. M. Gülker | https://mg.guelker.eu | PGP: Siehe Webseite
Passau, Deutschland  | kontakt@guelker.eu    | O<