bug#45224: 28.0.50; eww and GIFS (cpu usage shoots through the roof)

[Lars Ingebrigtsen <larsi@gnus.org>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> The struct also seems more clean to me.  Perhaps there are some
>> performance implications I'm not thinking of?  Or perhaps there is
>> some even better way to do the cache check than a struct, such as
>> using the "image struct" directly?
>
> The problem is that it's not well-defined which elements in the plist
> really affect display and which ones don't.  If you change :max-width of
> an image plist, then it should definitely affect display, but if you
> change :gazonk, then it shouldn't.

And as I was looking at the image stuff anyway, I've now gone ahead and
added filtering for the animation elements from the image cache.

In my test GIF image, Emacs used to use 30% CPU when animating it.
Creating the GIF cache took that down to 3%.  Fixing the first-level
image cache takes that down to 1%.

So finally Emacs should be usable when displaying a buffer with a bunch
of animated images.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no