From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#58875: 29.0.50; emoji-insert triggers a Lisp error Date: Sun, 30 Oct 2022 18:31:47 +0100 Message-ID: <87leoxp69o.fsf@gmail.com> References: <87eduqml1d.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lars Ingebrigtsen , Jonas Bernoulli To: 58875@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 18:32:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opCAh-0001lI-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 18:32:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opCAG-0007aL-G8; Sun, 30 Oct 2022 13:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opCAF-0007aA-Bw for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 13:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opCAF-00021w-4T for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 13:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opCAE-0002sa-DS for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 13:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 17:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58875 X-GNU-PR-Package: emacs Original-Received: via spool by 58875-submit@debbugs.gnu.org id=B58875.166715111711057 (code B ref 58875); Sun, 30 Oct 2022 17:32:02 +0000 Original-Received: (at 58875) by debbugs.gnu.org; 30 Oct 2022 17:31:57 +0000 Original-Received: from localhost ([127.0.0.1]:38973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opCA8-0002sH-It for submit@debbugs.gnu.org; Sun, 30 Oct 2022 13:31:56 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:36651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opCA6-0002s3-T4 for 58875@debbugs.gnu.org; Sun, 30 Oct 2022 13:31:55 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id j15so13050762wrq.3 for <58875@debbugs.gnu.org>; Sun, 30 Oct 2022 10:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HB8iv42P1tzON/38bsFJvu2CEvzEnkWm0tZS9/229U4=; b=YIKXar9X1FI+N3BqvR/x8/JF5m1sN+kxECCycCsjLEhFAyZh/aT0+C+GGzZ2vRabsc AG1fGNkdXJaJdYRv3by+A1r/LumN+LmjBTDbRNYC18rWp4IlKPhBMfOfIZlyn63z3/cP +rrZkYp3z4uDGpl+k9a3GLb+wXnyeaFwsLpzE7rYsRjZeM3R4HxEkqOcq5DThsLolHgN QWyAkUdibMBIJ2OqHh4Vd7sRz7rzNJ8F7+B8qctTH9OVpMPPqqCuWIfC0MDMgRmy+7w7 JoGRq7SLkqUoTZdJ6F24IuV16NBUvkdL6Nm8699ZHuvIbzMNhckKQtcrBkrJG0x/LVJ8 IQHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HB8iv42P1tzON/38bsFJvu2CEvzEnkWm0tZS9/229U4=; b=ZeH8Pad1HYlRpr1xMkVdzucfuDIoOsjGROyilVmKs9yAamoOWJ3m0caF47gzPaO3NP VQ04Pi3YSu1lVJZaBTIJIDWUJg9R6rUEK/2XJ2XbkSzyUia+aAdpgNW/jfEq0GT8YHLE KbZz8G223V3oiQXPflYvjb7sD7ZFN7l6J49JUr/lX++hbyji4at4EW3Z7weKqe/uAxGO eBc5RsIUedRQGtbyCKmXumzJ9xclI30u4yjycFFw+rtweYTAwSS6RYZ/cOKCCwo/DZRU bBkiFc48m4TlYidU1wHgMFnf7n+2u5td1GyNK7TXgvYEPsTVN6Nklz7rEhzH7aCl5WG4 xg2Q== X-Gm-Message-State: ACrzQf0gt/jiPtoML67CEh54VTGO+LDDpoCDWNi9k0HeTrR5hYqsHJu8 F9P+zPWAKe3ix6/N1lnH2ZY= X-Google-Smtp-Source: AMsMyM6sLJF2+hBVqgQqnAh8io4dQzq91UkLk3Yp+HQ3YlGCGx50MisxViuU0MY1VkCjoyJX3oEiSg== X-Received: by 2002:a5d:4688:0:b0:236:8e4d:5cb3 with SMTP id u8-20020a5d4688000000b002368e4d5cb3mr5768750wrq.710.1667151108640; Sun, 30 Oct 2022 10:31:48 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id y2-20020adffa42000000b0022e3538d305sm5445193wrr.117.2022.10.30.10.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 10:31:48 -0700 (PDT) In-Reply-To: <87eduqml1d.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Sat, 29 Oct 2022 22:28:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246639 Archived-At: K=C3=A9vin Le Gouguec writes: > If I revert 2022-10-28 "* lisp/transient.el: Update to package version > v0.3.7-173-g81b29ca" (de5a3fa1e5), then I no longer get an error. > > Haven't dug deeper yet. FWIW it's not clear to me if the fault lies on > the side of transient.el or emoji.el: Magit and rg.el's transients work > fine AFAICT. Bisecting the transient repo with=E2=80=A6 ~/src/emacs/master/src/emacs -Q --batch \ -L ~/.emacs.d/elpa/compat-28.1.2.2 \ -L ~/src/emacs/transient/lisp \ -eval '(emoji-insert)' || false =E2=80=A6 points to: ea851f3bde0b769b04ad03ab1a1341c013d0ddc6 is the first bad commit commit ea851f3bde0b769b04ad03ab1a1341c013d0ddc6 Author: Jonas Bernoulli Date: Thu Oct 20 12:19:22 2022 +0200 Turn suffix specifications into code instead of data The macro `transient-define-prefix' manipulates its GROUP arguments, but until now it expanded to new vectors using vector syntax, i.e., data. An effort was made to evaluate lambda expressions, but that did not really work. Now the GROUP arguments are expanded into code, which evaluates to new vectors. This way lambda expressions are automatically evaluated and byte-compiled, but we now have to take care to quote certain lists and symbols. Functions such as `transient-insert-suffix' take group and suffix specs of the same form as `transient-define-prefix' but because there is no macro expansion step, they have to `eval' the result of parsing these specifications. Add a new macro `transient-define-groups', which can be used to define suffix groups that are shared between multiple prefix commands, but don't use it for `transient-common-commands' to avoid having to make a bunch of functions available at compile time. Still haven't actually looked at what the fuss is about. Based solely on emoji.el's use of internal transient-- functions, I'd be tempted to conclude that emoji--define-transient needs to be updated =F0=9F=A4=94