From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#58800: Mark previous-buffer and next-buffer commands as repeatable Date: Sun, 30 Oct 2022 07:35:04 +0100 Message-ID: <87leoxom3r.fsf@cassou.me> References: <87v8o6zkes.fsf@cassou.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2038"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 58800@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 07:36:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op1vx-0000JR-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 07:36:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op1vR-0000WM-9q; Sun, 30 Oct 2022 02:36:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1vP-0000W5-2h for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op1vO-0002yv-Qu for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op1vO-0007wt-ET for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58800-submit@debbugs.gnu.org id=B58800.166711171530479 (code B ref 58800); Sun, 30 Oct 2022 06:36:02 +0000 Original-Received: (at 58800) by debbugs.gnu.org; 30 Oct 2022 06:35:15 +0000 Original-Received: from localhost ([127.0.0.1]:37171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1ud-0007vX-1A for submit@debbugs.gnu.org; Sun, 30 Oct 2022 02:35:15 -0400 Original-Received: from mail.choca.pics ([80.67.172.235]:33090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1ua-0007vL-3I for 58800@debbugs.gnu.org; Sun, 30 Oct 2022 02:35:14 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 80410181942B3; Sun, 30 Oct 2022 07:35:10 +0100 (CET) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 8xacRWjxEvh5; Sun, 30 Oct 2022 07:35:09 +0100 (CET) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id D75A5181942BF; Sun, 30 Oct 2022 07:35:09 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id TAUC_0Z1QegW; Sun, 30 Oct 2022 07:35:09 +0100 (CET) Original-Received: from localhost (153.226.95.79.rev.sfr.net [79.95.226.153]) by mail.choca.pics (Postfix) with ESMTPSA id 7EFA8181942B3; Sun, 30 Oct 2022 07:35:09 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246588 Archived-At: --=-=-= Content-Type: text/plain Hi Stefan, Stefan Kangas writes: > Damien Cassou writes: > Do we really need to add "Copyright-paperwork-exempt"? I don't, you are right. Fixed. >> +(defvar-keymap buffer-navigation-repeat-map >> + :doc "Keymap to repeat `next-buffer' and `previous-buffer'. Used in `repeat-mode'." >> + [right] #'next-buffer >> + [left] #'previous-buffer) > > It should be "" and "" here, I think. You are right. In the meantime, I switched to Emacs 29 so I can test my own patches. Sorry. Fixed. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Mark-previous-buffer-and-next-buffer-commands-as-rep.patch >From c09670b9baa5d5333ba2f9396915b01062b1f2a8 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 26 Oct 2022 17:12:14 +0200 Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as repeatable * lisp/bindings.el (buffer-navigation-repeat-map): Add new map. * lisp/bindings.el (previous-buffer): (next-buffer): Mark as repeatable. --- lisp/bindings.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/bindings.el b/lisp/bindings.el index 2e32128274..bd0bf5afd6 100644 --- a/lisp/bindings.el +++ b/lisp/bindings.el @@ -1029,6 +1029,14 @@ ctl-x-map (define-key global-map [XF86Back] 'previous-buffer) (put 'previous-buffer :advertised-binding [?\C-x left]) +(defvar-keymap buffer-navigation-repeat-map + :doc "Keymap to repeat `next-buffer' and `previous-buffer'. Used in `repeat-mode'." + "" #'next-buffer + "" #'previous-buffer) + +(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map) +(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map) + (let ((map minibuffer-local-map)) (define-key map "\en" 'next-history-element) (define-key map [next] 'next-history-element) -- 2.36.2 --=-=-=--