From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] 11 new packages! Date: Fri, 25 Nov 2022 07:22:12 +0000 Message-ID: <87lenz1ot7.fsf@posteo.net> References: <87r0y6ug9z.fsf@disroot.org> <87y1sct2hp.fsf@posteo.net> <87k03vf5m8.fsf@disroot.org> <87edu2narn.fsf@posteo.net> <8735aieqtr.fsf@disroot.org> <87cz9mlq3o.fsf@posteo.net> <875yfdd5ad.fsf@disroot.org> <87tu2n1p5v.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Developer List To: Akib Azmain Turja Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 25 08:22:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyT2r-0007ai-K3 for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Nov 2022 08:22:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyT2V-0007vM-4l; Fri, 25 Nov 2022 02:22:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyT2O-0007tu-T2 for emacs-devel@gnu.org; Fri, 25 Nov 2022 02:22:18 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyT2N-0005Wu-5G for emacs-devel@gnu.org; Fri, 25 Nov 2022 02:22:16 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0999E240029 for ; Fri, 25 Nov 2022 08:22:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669360933; bh=H3pbzGZVQfvlZz40uoAJwOeZLJKzi8UtTqv9DDS8JvM=; h=From:To:Cc:Subject:Date:From; b=q6BFjPcd+yKzY4u5NHU48NE5YlnyQrcbVVBDU4/6CLfZ2VS/3+bwG1fsn6E++hZ7b P0QFXFyRPMUcbKRbyw2K0N84KbXWdDYytjfAbT4mi0dbvzlUmaWEFJS53Ob5uS2Wfm aspZwofw8LH6Zk6W8EU42aaBtKgkUds48Om5sCn1K/3vFnYw/SIQ+C8szkGUIi/pmb LJh4jcL1vQPGxjCmWIYKMXXYpTmIUVbnNDeVW+0iZba4RcUvKGrYi/H8BD+lIV1jhY lZFx0CHWdYJ6rWvSFbFxQbTzxn8AbQcXxRm6+FtV1wm3cyejrzb400fVGxlj6OIatr 1gvw1iSlT9pIg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NJRBq4bDqz6tmx; Fri, 25 Nov 2022 08:22:10 +0100 (CET) In-Reply-To: <87tu2n1p5v.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 25 Nov 2022 07:14:36 +0000") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300466 Archived-At: --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Akib Azmain Turja writes: > >> Philip Kaludercic writes: >> >>>>> OK, then adding them to NonGNU ELPA seems like the safer bet. >>>>> >>>>> I'd like to add them, but I'll have to take the time to review them >>>>> first, which might take a bit. >>>> >>>> What do you want to review? The patches, or the packages? >>> >>> The packages, unless you aren't interested in comments. >> >> Review if you wish, I welcome feedback. > > Sorry for the delay, here are a few more comments: [...] > blow: Attached the wrong file here: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=comments.diff diff --git a/blow.el b/blow.el index 15cfd75956..974f745d6b 100644 --- a/blow.el +++ b/blow.el @@ -93,7 +93,7 @@ (defun blow--set-mode-list (symbol value) "Set SYMBOL's default value to VALUE, SYMBOL should be `blow-mode-list'." - (set-default symbol value) + (set-default symbol value) ;perhaps `custom-set-default' would be better? (when blow-mode (blow--setup-all-buffers))) @@ -111,12 +111,12 @@ Don't modify this variable from Lisp programs, use `blow' instead." (sexp :tag "Mode line template"))) :set #'blow--set-mode-list) -(defvar blow--original-lighters nil +(defvar blow--original-lighters nil ;why isn't the value initialised? "Hash table of modes and their original lighters or nil.") (defun blow--hash-exists-p (key table) "Return t if KEY is in hash table TABLE." - (let ((default (make-symbol "blow--nonexistant"))) + (let ((default (make-symbol "blow--nonexistant"))) ;the prefix is not necessary, the symbol isn't interned anyway (not (eq (gethash key table default) default)))) (defun blow--puthash-unless-exists (key value table) --=-=-=--