From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: F. Jason Park Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 00de296d1b 3/3: Simplify erc-sasl's auth-source API Date: Tue, 29 Nov 2022 06:44:16 -0800 Message-ID: <87lentizwf.fsf@neverwas.me> References: <166969908095.16328.16275737650099622826@vcs2.savannah.gnu.org> <20221129051801.9344CC0009E@vcs2.savannah.gnu.org> <875yeywawz.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 29 16:05:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p02Ae-0007B6-NM for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Nov 2022 16:05:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p029U-0006EX-8I; Tue, 29 Nov 2022 10:04:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p01qV-0000py-Ui for emacs-devel@gnu.org; Tue, 29 Nov 2022 09:44:27 -0500 Original-Received: from mail-108-mta129.mxroute.com ([136.175.108.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p01qT-0001v3-Tj for emacs-devel@gnu.org; Tue, 29 Nov 2022 09:44:27 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta129.mxroute.com (ZoneMTA) with ESMTPSA id 184c3d88b600006e99.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 29 Nov 2022 14:44:19 +0000 X-Zone-Loop: d1380b78d0345a2faf202af5802aca62035cea27aa61 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XIwyZqsl7+qIglvGogsTQ4w4px592FNeYRjGhH6JD2w=; b=Qnj5/T7+jylKXo7Xzu7oNGgNjQ GRPvdgIXmUmrsrWZlM38s5JHnKI8bJ17l5AQZACzaLS8kORC3VkDvRgG54A5VuKNnRFIPll6pTfT6 NXNIpAu09ONvJ9ZUAWDMXgsqoP5H/zcGUgTaVcmCqpFXwFdVHsoD2hwFkV7zBpXX5StIbR/Ljkjl3 H1X2GdtN0ryhMpvq054+SemoPJqXv8frgztY2o70oZp5aqqRq2yLfkH4+l0xG3Zpq4GslJqzouyx7 R1ijhzOxcV278DDwMzdjPm4LvaEWbGqAYrEf4sZXe6Z7aW7M23bkfUFP2l8EOv6KGqKOT6m9FqNkx YCuWg8Nw==; In-Reply-To: <875yeywawz.fsf@yahoo.com> (Po Lu's message of "Tue, 29 Nov 2022 14:07:56 +0800") X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.129; envelope-from=jp@neverwas.me; helo=mail-108-mta129.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 29 Nov 2022 10:04:02 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300712 Archived-At: Po Lu writes: > Amin Bandali writes: > >> branch: emacs-29 >> commit 00de296d1b4f629fd828cdeff588bb4f742d9ffe >> Author: F. Jason Park >> Commit: Amin Bandali >> >> Simplify erc-sasl's auth-source API >> >> * doc/misc/erc.texi: Revise descriptions in SASL chapter to reflect >> simplified auth-source options. >> >> * lisp/erc/erc-sasl.el (erc-sasl-password, >> erc-sasl-auth-source-function): Revise doc strings. >> (erc-sasl-auth-source-password-as-host): New function to serve as >> more useful choice for option `erc-sasl-auth-source-function'. >> (erc-sasl--read-password): Promote auth-source to pole position, above >> an explicit string and `:password'. >> >> * test/lisp/erc/erc-sasl-tests.el (erc-sasl--read-password--basic): >> Massage tests to conform to simplified `erc-sasl-password' >> API. (Bug#29108.) > > Was such a big change really a regression fix, suitable for emacs-29? My apologies. Won't happen again. The file it updated was first introduced five days back and contained a poorly designed option (by me) that threatened to become a maintenance nuisance and a possible source of user frustrations (and maybe bug reports). Basically, it suggested a new type (symbols) be assigned to a decades-old variable, `erc-session-password', without a thorough vetting of the repercussions. The change in question tried to undo some of that short-sightedness, albeit too elaborately (and thus irresponsibly), given the timetable. (FWIW, that should be the last you'll hear from ERC for Emacs 29, other than incrementing our version number to 5.5 to keep the releases in sync.) Appreciate your vigilance and understanding (and all your work on Emacs).