From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Wed, 04 Jan 2023 21:56:29 +0100 Message-ID: <87lemi6mte.fsf@betli.tmit.bme.hu> References: <6829F6A2-C6FD-4807-B3D2-1E740ED496BC@gmail.com> <87zgb6gu71.fsf@posteo.net> <87v8lugtou.fsf@posteo.net> <87k0297wtp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36202"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Yuan Fu , 60338@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 04 21:57:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDApJ-0009Gi-1B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Jan 2023 21:57:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDAos-00045d-He; Wed, 04 Jan 2023 15:57:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDAor-00045J-NZ for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 15:57:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDAoo-0004sd-Vp for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 15:57:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDAoo-00045z-Ek for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 15:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60338-submit@debbugs.gnu.org id=B60338.167286580015708 (code B ref 60338); Wed, 04 Jan 2023 20:57:02 +0000 Original-Received: (at 60338) by debbugs.gnu.org; 4 Jan 2023 20:56:40 +0000 Original-Received: from localhost ([127.0.0.1]:49743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDAoS-00045I-0t for submit@debbugs.gnu.org; Wed, 04 Jan 2023 15:56:40 -0500 Original-Received: from mail-ed1-f44.google.com ([209.85.208.44]:36550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDAoQ-000454-5p for 60338@debbugs.gnu.org; Wed, 04 Jan 2023 15:56:38 -0500 Original-Received: by mail-ed1-f44.google.com with SMTP id m21so50233139edc.3 for <60338@debbugs.gnu.org>; Wed, 04 Jan 2023 12:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=MKcuKpRQqn8vRy/oaCUA+G44NpbIVBgYvr5c3AXHU+M=; b=LnpevdGYS4nrAYecjVzVZX+5w7WqmHEdGWOnexc1DdMu9olDHfYHpScSKosgsYchDo XiMoC/2OexCIjQHYIy75CQ7BqVe092hPhqt+haSVHHcrqHuXkFftzlacHGD01/yYHmtP uWf+16AQwAAHClvVTNS1u2sV/CWktAUFuw9Dp6WTd2RD91JrUgVj6+aIKDZBtqOwcieU 4kBWJN4XbOpPfM6P4fT47wIMnOeJcpHXkgVtm0reaISW5KepYBMPOv6jRdm82LYq6Uik vLuvxZSPanHC5DPVn0py0b+SobQyu120czdxjEQKDLFZilLs7GhtxIYC50o4lzTqw0Uf rnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MKcuKpRQqn8vRy/oaCUA+G44NpbIVBgYvr5c3AXHU+M=; b=6c9dGtm0f8OlSa4ndt7ENBpnBvXOUG3NLsRm4/AH+AOTs7tZN9c8e2IVRByC7/DofP lZPQsFYOmUk1n4Sr+x5gyDsMRrQZeCRi/7BBH9rCcFltuBN5C8pxuQRPtjVsRHLSVlPu gUwDBguj5xZ5guw9qB31xClWFHWkLNe5SyP1neQms7px1xC0AUn+0vTp5rjFmvAPzphX SIKPKWcXc3wT55YEAKgRHGaHlUSQc0OUnT0EQnLkIQ2elYTuXpjIK5ibYdZKeFZ80/U4 YNljKE9p/8LcuZo94GbRJHXGQKacsW/bCitrCnvrIpV0vQdhqNSdW8ASkxHac3Ogfucu 1XVA== X-Gm-Message-State: AFqh2krWds3JG9uvEPM8mtZ1S3WS2XF3PoxKs+IJoEtquLHr+8RJiidS khDTEhy1zklfO0WSATngEf9exRqaA48= X-Google-Smtp-Source: AMrXdXuOsrV5LnzzSOMUbEw5TKD0u6euL6/c3fsFlUiPTlKQyXcTvDgnfn/5oYbbNMSkwVgg5tpQCA== X-Received: by 2002:a05:6402:ca8:b0:490:30a0:21be with SMTP id cn8-20020a0564020ca800b0049030a021bemr2041275edb.18.1672865791678; Wed, 04 Jan 2023 12:56:31 -0800 (PST) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id l26-20020a056402125a00b0046b471596e6sm15376563edw.57.2023.01.04.12.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 12:56:30 -0800 (PST) In-Reply-To: <87k0297wtp.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 30 Dec 2022 15:09:06 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252539 Archived-At: This is going to be a bit off-topic, but I'm guessing that users (after a while) get used to what they can expect from a specific language server when it comes to code-actions. And with a well written server, users should never want to partially apply a server initiated text-edit. Therefore it might be a better UI to apply every text-edit without questions, display a message when the changes are not visible ("Changed 100 lines in 10 files"), provide a command to view the last text-edit as a diff, and allow the users to undo the change with a single undo command. This UI wouldn't slow down experienced users, and it would allow them to quickly correct rare mistakes. Eglot could also teach inexperienced users with messages like "Changed 2 lines in 1 file. `undo-view-last' shows the change." WDT?