From: Ihor Radchenko <yantar92@posteo.net>
To: gautier@gautierponsinet.xyz
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: New face: org-agenda-calendar-timerange
Date: Fri, 20 Jan 2023 11:24:45 +0000 [thread overview]
Message-ID: <87lelxsb2a.fsf@localhost> (raw)
In-Reply-To: <12a8d2e8b36fb5c6f61a2b084e22a7b8@gautierponsinet.xyz>
gautier@gautierponsinet.xyz writes:
> Please find attached a patch containing two commits.
> The first one applies the face `org-agenda-calendar-event' to entries
> with a time range within a single day.
> The second one defines the new face `org-agenda-calendar-daterange'
> and applies it to entries with a time range on several days. (The
> second commit assumes the first one is already applied.)
>
> Since I am still learning elisp and this is my first contribution, it
> would be very nice if someone could double check the patch, and any
> feedback would be very welcome.
The patch looks good.
Now, just waiting for confirmation from Bastien about your copyright
status records.
> By the way, while trying to understand the code I have discovered the
> commit "cb19f5c94e3dc94da78169ec675d5bd07af34427" by Bastien which I
> don't really understand. The commit message says, talking about
> entries with a timerange:
> "* lisp/org-agenda.el (org-agenda-get-blocks): When both dates are of
> the same value, assume this is a time to display for each date in the
> range."
>
> It seems to me that this should be done by creating repeating tasks
> rather than an entry with a timerange, because suppose I want to put
> in my agenda an event spanning on several days including the precise
> hours at which it starts and ends but which starts and ends on the
> same hour, for example an entry with the following timerange:
>
> <2023-01-19 jeu. 12:00>--<2023-01-26 jeu. 12:00> .
AFAIU, the commit fixed a different scenario:
https://orgmode.org/list/BYAPR07MB573496C31816FE64B71E9D70A5CD0@BYAPR07MB5734.namprd07.prod.outlook.com
<2019-08-05 Mon 08:30-11:00>--<2019-08-09 Fri 08:30-11:00>
(which is, by the way, is not a proper time range, according to Org syntax)
Bastien, the commit asserts that when time parts of the timestamp range
are equal, treat them as repeating event, like <2019-08-05 Mon 08:30-11:00 +1d>
However, when there is an actual date range as in Gautier's example,
things are broken.
I am inclined to revert your commit because the original bug report was
trying to make Org use timestamp format, Org does not really recognize.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-01-20 11:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 16:56 New face: org-agenda-calendar-timerange Gautier Ponsinet
2023-01-17 11:20 ` Ihor Radchenko
2023-01-17 22:25 ` gautier
2023-01-18 10:08 ` Ihor Radchenko
2023-01-18 15:41 ` gautier
2023-01-18 16:01 ` gautier
2023-01-19 11:00 ` Ihor Radchenko
2023-01-19 21:58 ` gautier
2023-01-20 3:32 ` Ruijie Yu via General discussions about Org-mode.
2023-01-20 4:24 ` Ruijie Yu via General discussions about Org-mode.
2023-01-20 11:24 ` Ihor Radchenko [this message]
2023-01-20 11:36 ` Bastien Guerry
2023-01-21 8:27 ` Ihor Radchenko
2023-01-21 8:29 ` Ihor Radchenko
2023-01-21 22:44 ` Gautier Ponsinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelxsb2a.fsf@localhost \
--to=yantar92@posteo.net \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=gautier@gautierponsinet.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.