From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Sun, 09 Apr 2023 18:08:27 +0200 Message-ID: <87lej1ca2s.fsf@gmx.de> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile5gv0c.fsf@tcd.ie> <874jppb388.fsf@tcd.ie> <87ttxpf725.fsf@gmail.com> <87pm8dcbr7.fsf@gmx.de> <87o7nxf44b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34213"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Basil Contovounesios , 62694@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 18:09:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plXbW-0008lp-T5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 18:09:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plXbF-000597-0A; Sun, 09 Apr 2023 12:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plXbD-00058u-Qe for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 12:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plXbD-0000ny-5a for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 12:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plXbC-0007cK-Iv for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Apr 2023 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.168105651929247 (code B ref 62694); Sun, 09 Apr 2023 16:09:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 9 Apr 2023 16:08:39 +0000 Original-Received: from localhost ([127.0.0.1]:33568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plXao-0007bf-Gj for submit@debbugs.gnu.org; Sun, 09 Apr 2023 12:08:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:52265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plXal-0007bN-Gd for 62694@debbugs.gnu.org; Sun, 09 Apr 2023 12:08:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1681056508; i=michael.albinus@gmx.de; bh=dmZmRjnI5rGA66Oy+rpbO4sT1CoBzY9YgVZfvTaEIDc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=VrhOczPDYMWZW3fqDKWwKnHtHmXgLiU0yuTK5KsVvb+sYfCnz5ygXQaGB0AMCN3FR ZOnNmohGZmUS4JierblcLBH8ngLtCr7FHB8kBIzKvo4yFxD2DENdgSD/WtA1ico/Hf iGFtwNwUWRVx+DDOzeDftLn7OHEq999z1VUEE1zmPN6gnV4c3rnf5xIViZyaDchoQA YWSeD4p0E8sxPtgFT7DAff6u/CfZ42hNyMf4Uzj3iAUgGcuvjGQoR2au0KholAIAJg EsK8ge6HYp+Oo6g1gbetFAwBvn2iHmLUImqtrpjjbfu81LIIFazHclYn7kAVUQWcE7 I5JSQVmxY+ZQQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MCKBc-1pc9eg1Lec-009QyB; Sun, 09 Apr 2023 18:08:28 +0200 In-Reply-To: <87o7nxf44b.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 09 Apr 2023 16:48:52 +0100") X-Provags-ID: V03:K1:LE/TAr6gizREPOicqBIfIxUfIeuTWMHee0JTlNYvfOwLtjx/fUW PuBlcC0NDlYswJFdoK8D8tiz4fd91u6LWUTTOVyn8syAqWqk0lBUBMb6IISFkJcO/defF4n 3r+jvtTHY+DlHa273Gnh+t2Z/CV76FQZUzRx1OH6gVOtMJ/JejlFT+hdnC9QBIyA2mhNU+K 0TwEftYYUJ68xhSDNPzVw== UI-OutboundReport: notjunk:1;M01:P0:jns4f0ZKJd0=;ynU8zdfsYPli+xayv2Rft0YV0yz MX69FLzPpRtM6LRN6vb5RdbfcRn0S/i3fJjH1ng/kmBrJfZ3dwvCOEDhOsfToeI9S1QdJ3yvO TNRyDqsOsXJPQqiv/vDy/ywSh5y+x6TkI6TTEuz39AlmGHkBeRfySVTr2JUbhGiL1aSQ3znHC l60rYFinXX10+zWf2eBFijD7U/3tKhruWMgFPHMmhK87Y9hF54VQ54IsJDD+ZBuSaMAeWk1iG /1bwZw+jmbSkqpWKxilUTMtifcOAq3v4bfqSyvqKpAS6Odq6IwVQ+pouOLK6XpL0PTMzjgXP2 5niXjBvCWxESdu0dwcQHNzcrjcV3bWBPoYJ8JQ3b44RnP/FRdhd0C/yhUeAIB0D3S6SzQSIji DN7mfaIixfJs9XdUFhp5Cp6q5sWE/SmIxf/hRk2JFr+mI/tbtaLhUW1uunI3VAks/+i535I4D inaE5I+nFtKqEJ3tcuiKk3Ls63Vr+e9hpVgfaQDUf4ePHd6mrVtWpTKGj8bmE0D0SUtnhgscr gp1kfHTWdQpgqSoK7swIqB82fjuh3qS9kfYJBzpfTqLUa4V1CERxuDtSAsAR1DT+PZYc2ZC9D TTgZ7oRFeywPt4DDD3GcXyCgwq3FfmO6K47nPqwO6HVIUP8L76opZiY9qbf6GznstN/zK3+I9 t6v6Cu2UK2PPmTKWTjNXz01BNJOqsyqfzfQhlBMx35VO8eLQePrBYHz78PEN2bAM7cHVJv0ee +1HZxPFOvZbHNZpthUfI5yXAaBnMeoUUpxKUyKX6AEhKR7A5nijE0VcWo869AwoFmU5CdUF1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259525 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >>>> That earlier proposals were not complete, optimal, or up to yours or >>>> anyone's standards does not warrant degrading them, IMO.=20=20 >>> >>> - vague: there are no details, just the idea of "checking if the server >>> is up to the job". >> >> I've shown you the Eglot traces for one test case on both Debian pylsp >> (failed) and Fedora pylsp (succeeded). I still have no idea whether the >> Debian flavour is inside the LSP specs or not. But if it returns >> out-of-spec replies, I guess eglot should raise an Emacs error >> indicating this fact. > > It's _not_ an out-of-spec reply. It's just a insuficient in-spec reply > from a poorly installed or configured server. If it is an on-spec reply, eglot shall handle this. If there isn't sufficient information in the reply, eglot shall err out with this information. > The point of these tests, as I've explained multiple times, is not to > test the servers, rather eglot.el's particularly its interactions with > other emacs facilities, such as xref, completion, flymake etc. Any > server will do, as long as it is reasonably well-behaved and > predictable. That's why I switched to clangd and all this discussion > is moot now. It isn't only the tests. You cannot prevent that a curious user, with the brand new Emacs 29 installed, reads the NEWS and knows there's eglot. She installs the Debian pylsp server (because that's what Debian offers), tries it, and fails. And you'll ghet a bug report. >> Based on this fact, you could always catch this specific error in the >> tests, and say that the server is not suited. Whether you shall skip >> or err out the test then is something else; until now it isn't obvious >> that a failed eglot test is due to the (possible) server misbehavior, >> or due to an eglot error. At least this information should be shown. > > It's impossible to know that. You can design perfectly in-spec naughty > servers breaking all of eglot tests. Eglot shall fail the gracefully. The error messages I have seen so far don't tell me anything. > Or you can follow Eglot's maintainer advice to install versions of > servers known to be working correctly. Heroically complexifying Eglot > to detect misbehaving servers is a completely futile exercise. That's an illusion. People don't follow advices, people don't read manuals. Believe me with 20+ years of Tramp experience, 40+ years experience in developing and maintaining large projects. > Jo=C3=A3o Best regards, Michael.