Re: [ANN] lisp/ob-tangle-sync.el

[Ihor Radchenko <yantar92@posteo.net>]

Mehmet Tekman <mtekman89@gmail.com> writes:

>> I feel confused when reading the modified code.
>>
>
> Okay, I guess comments are not my strong suit. I will try to remove any
> unnecessary comments and use better variable names.

No, comments were useful. They revealed that our understanding of the
expected behaviour might differ.

>> I recommend trying various edge cases with your patch.
>> In particular:
>>
>> 1. Testing exclusive group inheritance when we inherit a header arg
>>    value that matches :any:
>>
>>    #+PROPERTIES: header-args :tangle "foo.txt"
>>    #+begin_src ... :tangle no
>>
>>    #+PROPERTIES: header-args :tangle no
>>    #+begin_src ... :tangle "foo.txt"
>>
>>    #+PROPERTIES: header-args :tangle no
>>    * Heading
>>
>>    :PROPERTIES:
>>    :header-args: :tangle "foo.txt"
>>    :END:
>>    #+begin_src ... :tangle yes
> ...
>> I feel that the following code is not reliable when we inherit exact and
>> :any exclusive group members in alternations.
>
> Ah, hmm - can you give me an example here? I thought the idea was that
> an :any string would only be invokable once for a given header
> parameter.

See the above 3 examples: (1) "foo.txt" shadowed by "no"; (2) "no"
shadowed by "foo.txt"; (3) "no" shadowed by "foo.txt" then shadowed by
"yes".

You can also consider "foo.txt" shadowed by "bar.txt" and other
variations.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>